Fix: Support derived class objects in Delegate constructor (#20) #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #20 where creating a
Delegatewith a derived class object and member function pointer would fail during template argument deduction.Problem
The original constructor template required the object type and member function class type to match exactly:
This caused compilation errors when using derived class objects with inherited member functions:
Solution
Modified the constructor to accept separate template parameters for the object type and member function class type:
std::static_pointer_castto safely convert the derived object to the base classTest Results
Added comprehensive test cases that verify:
All tests pass, confirming both the fix and backward compatibility.
🤖 Generated with Claude Code
Resolves #20