Add tests for Google Maps StaticMapService and Locations Searcher#260
Merged
Conversation
Collaborator
fabionl
commented
Jan 25, 2026
fabionl
commented
- Implement comprehensive RSpec tests for Locations::GoogleMaps::StaticMapService, covering initialization, call behavior, query parameters, and edge cases.
- Introduce RSpec tests for Locations::Searcher, validating initialization, geocoding behavior, lazy enumeration, error handling, and integration with Geocoder and Parser.
- Ensure proper handling of various address inputs, including valid, invalid, and nil addresses.
- Validate performance aspects, including lazy evaluation and memory efficiency for large result sets.
- Implement comprehensive RSpec tests for Locations::GoogleMaps::StaticMapService, covering initialization, call behavior, query parameters, and edge cases. - Introduce RSpec tests for Locations::Searcher, validating initialization, geocoding behavior, lazy enumeration, error handling, and integration with Geocoder and Parser. - Ensure proper handling of various address inputs, including valid, invalid, and nil addresses. - Validate performance aspects, including lazy evaluation and memory efficiency for large result sets.
fabionl
force-pushed
the
feat/add-tests
branch
from
a077838 to
1a5c1b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.