Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Setup Ruby 3.4.5
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.4.5

- name: Cache gems
uses: actions/cache@v1
uses: actions/cache@v4
with:
path: vendor/bundle
key: ${{ runner.os }}-rubocop-${{ hashFiles('**/Gemfile.lock') }}
Expand Down
17 changes: 14 additions & 3 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ jobs:
--health-retries 5

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4

- name: Setup Ruby 3.4.5
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.4.5

- name: Setup Node 24
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: 24.9.x

Expand All @@ -55,7 +55,18 @@ jobs:
POSTGRES_PASSWORD: password
run: |
cp config/database.ci.yml config/database.yml
rake db:create db:migrate
bin/rails db:create db:migrate

- name: Precompile assets
env:
RAILS_ENV: test
PGHOST: localhost
POSTGRES_DB: rails_github_actions_test
POSTGRES_USER: rails_github_actions
POSTGRES_PASSWORD: password
PGPORT: ${{ job.services.postgres.ports[5432] }}
run: |
bin/rails assets:precompile

- name: Run tests
env:
Expand Down
2 changes: 1 addition & 1 deletion app/components/facilities/card_component.html.erb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="card facility mb-2", id: <%= card_id %> >
<div class="card facility mb-2" id="<%= card_id %>">
<header class="card-header level mb-1">
<div class="level-left">
<div class="card-header-title">
Expand Down
2 changes: 1 addition & 1 deletion app/components/facilities/discard_reason_component.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class Facilities::DiscardReasonComponent < ViewComponent::Base
def initialize(discard_reason)
super()

@discard_reason = discard_reason.to_sym
@discard_reason = discard_reason&.to_sym
end

def self.select_options
Expand Down
5 changes: 5 additions & 0 deletions app/views/admin/facilities/index.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@

<hr/>
<div class="container">
<% if @facilities.empty? %>
<div class="notification is-info">
No facilities found
</div>
<% end %>
<% @facilities.each do |facility| %>
<%= render Facilities::CardComponent.new(facility: facility) %>
<% end %>
Expand Down
4 changes: 4 additions & 0 deletions config/environments/test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,8 @@

# Raise error when a before_action's only/except options reference missing actions.
config.action_controller.raise_on_missing_callback_actions = true

# Compile assets in test environment for system specs and views that reference assets
config.assets.compile = true
config.assets.digest = true
end
4 changes: 2 additions & 2 deletions docs/plans/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Each `tracker.md` file should include:

| Plan | Status | Progress | Last Updated |
|------|--------|----------|--------------|
| [Test Coverage Implementation](./test-coverage-implementation/plan.md) | Not Started | 0/40 (0%) | 2025-01-18 |
| [Test Coverage Implementation](./test-coverage-implementation/plan.md) | Complete | 24/24 (100%) | 2026-01-26 |

## Plan Templates

Expand All @@ -79,7 +79,7 @@ When creating a new plan:

- **Not Started** - Plan documented but no work begun
- **In Progress** - Currently being worked on
- **Complete** - All items in tracker marked as completed
- **Complete** - All plan items successfully implemented
- **On Hold** - Work paused indefinitely

## Quick Reference
Expand Down
Loading
Loading