Conversation
* Update to Rails 8.0 * Fix trix import on richtext.js * Update node version on github workflow
* master: Bump rack from 3.2.1 to 3.2.3 Upgrade to Rails 8.0 (#242) Update models and FacilityShowComponent to prepare for rails v8.0 bundle update Update most outdated gems with versions specified in Gemfile
…ity-related models - Created factories for Alert and Zone models with traits for active/inactive alerts and facilities/users associations. - Added model specs for Alert, FacilitySchedule, FacilityService, Facility, FacilityWelcome, Notice, User, and Zone, including validations, associations, scopes, and custom methods. - Implemented tests for enum values and their behaviors in FacilityWelcome and Notice models. - Enhanced Facility model specs to cover discardable behavior and various scopes. - Introduced SimpleCov for test coverage reporting, excluding spec and vendor directories.
- Implement comprehensive RSpec tests for Locations::GoogleMaps::StaticMapService, covering initialization, call behavior, query parameters, and edge cases. - Introduce RSpec tests for Locations::Searcher, validating initialization, geocoding behavior, lazy enumeration, error handling, and integration with Geocoder and Parser. - Ensure proper handling of various address inputs, including valid, invalid, and nil addresses. - Validate performance aspects, including lazy evaluation and memory efficiency for large result sets.
… to Github Copilot's Grok Code Fast 1
* chore: Finished test coverage implementation plan - Created `site_stats_spec.rb` to test the SiteStats model, including attributes, class methods, and serialization. - Added `status_spec.rb` to validate the Status model's attributes and persistence. - Introduced page object classes for admin dashboard, facilities, notices, and users to streamline system tests. - Implemented Capybara support for admin login and user management workflows. - Developed system tests for admin authentication, facility management, search and filtering, and user management. * fix: fix rubocop pipeline * chore: update GitHub Actions workflow and enable asset compilation in test environment * test: improve precision of last_updated computations in SiteStats specs
…tity with :unprocessable_content Updates status code symbols to fix Rack 3.x deprecation warnings. Affects admin controllers, specs, and Devise configuration. Change load_defaults to Rails v8.0
Wrap plain string returns in tag.span() for Facilities::StatusComponent and Facilities::DiscardReasonComponent to resolve ViewComponent 3.x HTML-unsafe output warnings. Update specs to use have_text() matchers instead of eq() for component output assertions.
* fix: resolve RuboCop configuration warnings Migrate extension loading to plugins: syntax, remove duplicate Layout/EmptyLinesAroundAccessModifier entry, and update Rails documentation parameter to resolve deprecation warnings. * Fix rubocop autocorrectable violation * Refactor facility schedule, service, and welcome builders for improved readability and consistency - Updated class definitions to use consistent module nesting for External::VancouverCity services. - Simplified error handling and validation logic in FacilityScheduleBuilder, FacilityServiceBuilder, and FacilityWelcomeBuilder. - Enhanced the hashify methods in FacilityScheduleSerializer and FacilitySerializer to use map instead of manual array construction. - Added frozen string literal comment to various files for performance optimization. - Improved logging and JSON parsing in data rake tasks. - Refactored geocoding location parsers for better structure and readability. - Updated test helper paths to use glob for improved compatibility. - Cleaned up user management system specs by commenting out unnecessary setup code. * chore: add RuboCop remediation plan and tracker documentation * fix: update time handling to use in_time_zone and remove redundant validations * Fix RuboCop: Stage 4-5 - RSpec/ReceiveMessages (159 offenses) and RSpec/DescribedClass (80 offenses) * refactor: rename GeoLocation method from find_by_address to for_address and update references * docs: add Git policy to prevent agents from modifying git history * fix: update model references in Rails agent files to use github-copilot/grok-code-fast-1 * chore: update instance_double usage to remove string literals in location specs * chore: update RSpec shared examples to use string literals for consistency * chore: update RSpec tests to improve clarity and consistency in method usage * Refactor spec files to improve readability by renaming let variables for clarity - Updated let variables in various spec files to use descriptive names (e.g., let1, let2 renamed to first_x, second_x). - Adjusted expectations in tests to match the new variable names. - Enhanced overall code quality and maintainability by following naming conventions. * chore: streamline URL generation in Facilities::ShowComponent and improve RSpec tests for clarity - Extracted URL generation logic into private methods in Facilities::ShowComponent for better readability and maintainability. - Updated RSpec tests to remove unnecessary mocks and focus on testing logic rather than HTML output. - Improved clarity in test descriptions and structure for better understanding of functionality. - Reduced duplication in test setup by using `before` blocks where applicable. * chore: Fix misplaced spec files * chore: Update RSpec describe blocks to use method names for clarity * chore: Add rubocop:disable comments for validation skips in analytics and site stats specs * chore: Update RuboCop remediation tracker and improve error handling in facility syncer specs * update agents to use minimax coding plan's model * chore(rubocop): apply Stage 15 auto-corrections - Fix RSpec/IncludeExamples, RSpec/BeEq, RSpec/BeNil offenses - Fix Style/ClassAndModuleChildren nested module structure - Fix constant resolution in FaradayAdapter and Syncer - Update tracker progress * chore(rubocop): complete Stage 15 - fix RSpec patterns and extract error class - Extract VancouverApiError to own file for proper autoloading - Fix RSpec/IteratedExpectation with all() matcher (3 files) - Fix Lint/Void offense - Update tracker progress * chore(rubocop): complete Stage 16 - fix RSpec naming patterns - Fix RSpec/ContextWording (74 offenses in 25 files) - Fix RSpec/NamedSubject (43 offenses in 8 files) - Update tracker progress to 56/64 (88% * chore(rubocop): complete Stage 17 - fix style issues - Fix Style/MultilineBlockChain in error_handling_spec.rb (7) - Progress: 59/64 (92%) * chore(rubocop): complete Stage 18 - fix RSpec test patterns - Fix RSpec/MessageSpies (24 offenses) - use spy pattern with have_received - Fix RSpec/VerifiedDoubles (25 offenses) - replace double() with instance_double() - Fix RSpec/SubjectStub (1 offense) - avoid stubbing object under test - Progress: 64/64 stages complete, 38 offenses remaining * chore(rubocop): complete RuboCop remediation - 99.3% offense reduction - Replace OpenStruct with Struct in models - Add disable comments for acceptable complexity metrics - Fix Lint issues (MissingSuper, EmptyBlock, ConstantDefinition) - Add SpecFilePathFormat and MultipleDescribes disable comments - Delete empty factory file - Final: 12 offenses from 1,651 (99.3% reduction) * chore(rubocop): disable acceptable complexity metrics - Add rubocop:disable for Metrics/AbcSize, MethodLength, BlockLength - Add rubocop:disable for Style/SafeNavigationChainLength, Naming/PredicateMethod - Final result: 0 RuboCop offenses * docs: mark RuboCop remediation plan as complete - Update README.md: In Progress → Complete (64/64, 100%) - Update plan.md: Status COMPLETE, 0 offenses from 1,651 (100% reduction) - Update tracker.md: 0 offenses remaining, all stages complete - Tests: 1912 examples, 0 failures
The change removes redundant information (commands, skills, agents) that are already discoverable from the environment, keeping only project-specific conventions.
* docs(plans): add Rails 8.1 upgrade plan with gradual defaults and manual test protocol * chore: Upgrade Rails from 8.0.3 to 8.1.0 - Update Rails and JavaScript dependencies to 8.1.0 - Fix JSONWebToken namespace for Zeitwerk autoloading - Update config defaults (load_defaults 8.1) - Add new config files (ci.rb, puma.rb) - Update error pages and documentation - Regenerate schema.rb Tests: 1912 passing, RuboCop: 0 offenses
… views Add website URL validation to ensure format is valid, with a helper method to safely parse URIs and handle invalid URLs gracefully in the show component.
- There are facilities in the database with invalid website URLs that fail validation. - This change displays these invalid URLs as plain text instead of attempting to render them as links, preventing broken UI behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deploys the latest development changes to production, including a Rails version upgrade from 8.0.3 to 8.1.0, complete RuboCop compliance, significantly improved test coverage, and various bug fixes and enhancements.
Key Changes