fix(security): Stop leaking urls on browser navigation - #148
Open
dot-mike wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regards linkwarden/linkwarden#1643 - [Browser Extension] Extension attempts to search every single visited website
This security-bug fix prevents the extension from leaking browser history to the self-hosted linkwarden instance. I'm sure the bug also affects the paid cloud instance of linkwarden, which makes this a serious violation of privacy for users.
I would also take the time to mention that browser extension is not mentioned in the privacy policy https://linkwarden.app/privacy-policy - which is linked from google extension page
before the fix, all URL navigation
After the fix, only URLs I explicitly saved