fix: verify real Serena response compatibility (0.12.5) - #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real Serena 1.7 returns JSON strings inside structuredContent.result. WinCode previously serialized that envelope as the symbol payload, misclassified valid results and fell back to text scanning. Unwrap the single string-result envelope while preserving errors, empty results, malformed responses and unknown metadata.
Validation: full local check passed (313 pass, 1 existing optional skip), including fresh stdio and delivery verification; 52 targeted identity/fallback tests passed. Seven opt-in real Serena/Roslyn stages passed in an isolated C# fixture with production default timeouts: overload identities, ambiguity, marked reference lines for both overloads, direct upstream body oracle, legitimate empty results, actual process interruption with an unavailable restart, and inactive project. Owned PID exit and unchanged fixture source were verified. The body oracle is explicitly a direct upstream query; the current parent Codex connection is not claimed to be reloaded.
No new production dependencies or global PATH/config changes. Real upstream setup remains opt-in; the reusable acceptance command requires an existing installed command. Failed setup/check attempts and evidence boundaries are recorded in the work log.