fix: stabilize LocalText and error contracts (0.13.1) - #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalText previously returned declarations from comments and strings and omitted TSX/JSX files. This patch masks supported non-code regions before declaration matching, preserves source lines/signatures, invalidates old caches, and reports uncertain lexical boundaries as incomplete and uncached. The existing C# masker is shared with UI mapping; script/JSX parsing remains deliberately limited text analysis.
The E4 contract suite now covers partial trash moves, workspace recovery and UI serialization and runs in Node 22 CI. Unknown tools return JSON-RPC -32602 during normal admission; known tool errors keep domain details and matching JSON/structuredContent. Impact returns one JSON text block with all evidence and formattedReport retained, including the alias. Consumers of the former second Markdown block must read formattedReport.
Validation:
Actual Codex-client Roslyn acceptance is explicitly deferred by the user. Client configuration and installed Skill were not changed; no new dependency was introduced. Text references and complex syntax remain heuristic. Detailed local receipts and failed-attempt history are recorded in docs/codex_worklog.md.