fix: harden workspace boundaries and bound architecture analysis - #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Harden workspace execution and disk boundaries, and make architecture discovery bounded and cancellable. Repository-local git.cmd and executable fsmonitor settings no longer run through Git probes; linked worktrees are recognized and failed status checks remain unknown. Git probes require 2.36 or later.
Cache/trash paths reject existing links and junctions, cache mutations verify directory identity, and cleanup preserves legacy/unrecognized files. Architecture discovery rejects outside project descriptors and limits entries, descriptor bytes, project count and actual formatted MCP output. The C# whitespace counterexample no longer blocks declaration parsing. Partial trash outcomes and existing workspace recovery remain intact.
Validation
Remaining boundaries
No atomic sandbox against concurrent path replacement, no forced interruption guarantee for permanently stalled OS I/O, and no permanent overflow attachment lease. Fixed-project connections (N1), bounded admission (N3), production cleanup identity (A9), and remaining consumer/long-running validation stay on the roadmap. Desktop tests and existing Codex connections were not refreshed in this change. Required CI must pass for this PR head before merge.