reverted and changes Alert Channel changes as per latest API v4 changes by srbhaakamai · Pull Request #890 · linode/linodego

srbhaakamai · 2026-02-10T07:23:11Z

📝 Description

What does this PR do and why is this change necessary?

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

How do I run the relevant unit/integration tests?
srbha@blr-mpo40 linodego % export LINODE_TOKEN="" && export LINODE_API_VERSION="v4beta" && go test -count=1 ./test/integration -run "TestMonitorAlertDefinition" -v
=== RUN TestMonitorAlertDefinition_smoke
--- PASS: TestMonitorAlertDefinition_smoke (66.19s)
=== RUN TestMonitorAlertDefinitions_List
--- PASS: TestMonitorAlertDefinitions_List (1.37s)
=== RUN TestMonitorAlertDefinition_CreateWithIdempotency
--- PASS: TestMonitorAlertDefinition_CreateWithIdempotency (3.88s)
PASS
ok github.com/linode/linodego/test/integration 72.096s

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

Copilot

Pull request overview

Re-enables Monitor alert channel functionality and related integration tests, updating the Alert Channel model to match the latest API v4 shape.

Changes:

Re-enabled integration tests that depend on listing alert channels and selecting a channel ID dynamically.
Implemented AlertChannel types (including content/details blocks) and restored ListAlertChannels.
Added JSON unmarshalling for created/updated timestamps using parseabletime.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
test/integration/monitor_alert_definitions_test.go	Re-enables alert channel listing tests and uses live channel discovery for alert definition creation.
monitor_alert_channels.go	Restores alert channel API surface (types + `ListAlertChannels`) updated for API v4 response schema.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-10T07:24:43Z

monitor_alert_channels.go

-//	endpoint := formatAPIPath("monitor/alert-channels")
-//	return getPaginatedResults[AlertChannel](ctx, c, endpoint, opts)
-// }
+type AlertNotificationType string


Several exported types are missing GoDoc-style comments (comments starting with the identifier name). If this repo uses golint/golangci-lint, this will typically fail linting; even if not, adding brief comments improves API readability for library consumers.

Copilot · 2026-02-10T07:24:43Z

monitor_alert_channels.go

+	EmailAlertNotification AlertNotificationType = "email"
+)
+
+type AlertChannelType string


Several exported types are missing GoDoc-style comments (comments starting with the identifier name). If this repo uses golint/golangci-lint, this will typically fail linting; even if not, adding brief comments improves API readability for library consumers.

Copilot · 2026-02-10T07:24:43Z

monitor_alert_channels.go

+}
+
+// AlertsInfo represents alert information for a channel
+type AlertsInfo struct {


Several exported types are missing GoDoc-style comments (comments starting with the identifier name). If this repo uses golint/golangci-lint, this will typically fail linting; even if not, adding brief comments improves API readability for library consumers.

Copilot · 2026-02-10T07:24:43Z

monitor_alert_channels.go

+	Type       string `json:"type"`
+	AlertCount int    `json:"alert_count"`
+}
+


Several exported types are missing GoDoc-style comments (comments starting with the identifier name). If this repo uses golint/golangci-lint, this will typically fail linting; even if not, adding brief comments improves API readability for library consumers.

Suggested change

// EmailChannelContent represents the content for email alert channels.

Copilot · 2026-02-10T07:24:44Z

monitor_alert_channels.go

+}
+
+// ChannelDetails represents the details block for an AlertChannel
+type ChannelDetails struct {


Several exported types are missing GoDoc-style comments (comments starting with the identifier name). If this repo uses golint/golangci-lint, this will typically fail linting; even if not, adding brief comments improves API readability for library consumers.

Copilot · 2026-02-10T07:24:44Z

monitor_alert_channels.go

+}
+
+// EmailChannelDetails represents email-specific details for a channel
+type EmailChannelDetails struct {


Several exported types are missing GoDoc-style comments (comments starting with the identifier name). If this repo uses golint/golangci-lint, this will typically fail linting; even if not, adding brief comments improves API readability for library consumers.

Copilot · 2026-02-10T07:24:44Z

test/integration/monitor_alert_definitions_test.go

+	var channelID int
+	var fetchedChannelLabel string
+	var fetchedChannelID int


The test keeps three variables (channelID, fetchedChannelID, fetchedChannelLabel) but channelID and fetchedChannelID are always assigned to the same value. Consider storing the selected channel in a single local (e.g., selectedChannel) or asserting directly on channelID plus a single label value to reduce duplication and make the test intent clearer.

satkumar-akamai · 2026-02-12T06:31:13Z

@srbhaakamai

For the List Channels API, the content and details fields currently contain essentially the same data but with different structure. We have kept both fields for backward compatibility, but content will be removed from the response in the future.
Please ensure that the test suites do not heavily depend on the content field.
Please update the latest ENUM in Alert Status field in Alert Management APIs (provided in the api spec)

satkumar-akamai

Changes looks good as per API Spec.

yec-akamai

Overall looks good. Can you fix the comments please?

yec-akamai · 2026-02-13T15:49:25Z

test/integration/monitor_alert_definitions_test.go

@@ -208,33 +208,33 @@ func TestMonitorAlertDefinitions_List(t *testing.T) {
 }

 // TODO: Disable this test until we can query alert channels correctly.


nit: can you clean up the TODO comment as well?

yec-akamai · 2026-02-13T15:49:35Z

test/integration/monitor_alert_definitions_test.go

 	// TODO: use a fixed channel id for now until the alert channel has been fixed.
 	//// Get a channel ID to use


nit: can you clean up the TODO comment as well?

yec-akamai · 2026-02-13T15:49:44Z

test/integration/monitor_alert_definitions_test.go

@@ -48,27 +48,27 @@ func TestMonitorAlertDefinition_smoke(t *testing.T) {
 	assert.NoError(t, err)

 	// TODO: Use a fixed channel id for now until the alert channel has been fixed.


nit: can you clean up the TODO comment as well?

yec-akamai · 2026-02-13T15:51:07Z

test/unit/base.go

 	c.BaseURL = "https://api.linode.com/v4/"
 }

+// SetUpWithAPIVersion initializes the Linode client with a specific API version


It's not necessary to have this function. Our integration test is default to use v4beta, and unit test does not check the api version though.

yec-akamai · 2026-02-13T15:56:34Z

monitor_alert_channels.go

+
+// ChannelContent represents the content block for an AlertChannel, which varies by channel type.
+type ChannelContent struct {
+	Email *EmailChannelContent `json:"email,omitempty"`


omitempty is not necessary if the field is read-only. Same for the rest fields.

yec-akamai

Can you also run the integration test and re-generate the fixtures please?

yec-akamai · 2026-02-13T16:05:12Z

monitor_alert_definitions.go

+	AlertDefinitionStatusProvisioning AlertDefinitionStatus = "provisioning"
+	AlertDefinitionStatusEnabling     AlertDefinitionStatus = "enabling"
+	AlertDefinitionStatusDisabling    AlertDefinitionStatus = "disabling"


Just curious, is this already a change in the API response? I remember we didn't have these three status in the old response and they were represented by in_progress. If this is the case we will need to make changes to a wait_for function though.

reverted and changes Alert Channel changes as per latest API v4 changes

188dabe

Copilot AI review requested due to automatic review settings February 10, 2026 07:23

srbhaakamai requested a review from a team as a code owner February 10, 2026 07:23

srbhaakamai requested review from lgarber-akamai and psnoch-akamai and removed request for a team February 10, 2026 07:23

Copilot AI reviewed Feb 10, 2026

View reviewed changes

fix unit tests with apiversion change

adac490

yec-akamai self-requested a review February 11, 2026 14:31

srbhaakamai marked this pull request as draft February 12, 2026 06:19

Changed enum changes for Alert Defintion changes for Status

3a838d5

srbhaakamai marked this pull request as ready for review February 13, 2026 08:11

satkumar-akamai approved these changes Feb 13, 2026

View reviewed changes

yec-akamai reviewed Feb 13, 2026

View reviewed changes



	// EmailChannelContent represents the content for email alert channels.

		@@ -208,33 +208,33 @@ func TestMonitorAlertDefinitions_List(t *testing.T) {
		}

		// TODO: Disable this test until we can query alert channels correctly.

		// TODO: use a fixed channel id for now until the alert channel has been fixed.
		//// Get a channel ID to use

		@@ -48,27 +48,27 @@ func TestMonitorAlertDefinition_smoke(t *testing.T) {
		assert.NoError(t, err)

		// TODO: Use a fixed channel id for now until the alert channel has been fixed.

Conversation

srbhaakamai commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✔️ How to Test

📷 Preview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

satkumar-akamai commented Feb 12, 2026

Uh oh!

satkumar-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

yec-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

yec-akamai Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

yec-akamai Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

srbhaakamai commented Feb 10, 2026 •

edited

Loading