Add build script for pandas 2.2.3#84
Conversation
| @@ -0,0 +1,16 @@ | |||
| { | |||
There was a problem hiding this comment.
this file name is not proper, it should be build_info.json
|
@pranjalpatidar01 the PR needs multiple changes, please correct the file names, folder structure, script format. |
|
I’ve updated the PR with the requested changes:
|
| "docker_build": false, | ||
| "validate_build_script": true, | ||
| "use_non_root_user": "false", | ||
| "v0.2.*": { |
There was a problem hiding this comment.
this version should be v2.2.* to match the package version
|
@pranjalpatidar01 the script file is still not aligned as per the requirement. Please compare with existing scripts in this repo and update. |
|
Hi @namrata.bhave, I’ve updated the script and build_info.json to align with the existing repository conventions, corrected the naming/folder structure, and validated the build and test execution on UBI/RHEL 9.6 (s390x). Could you please review again when you get a chance. |
|
@pranjalpatidar01 Please update your script file to match the existing format. Refer to this example: build-scripts/a/async/async_ubi_9.3.sh Lines 4 to 11 in 28c87ac |
|
Hi @sankalp-sde , I’ve updated the pandas script header and formatting to align with the existing repository conventions and pushed the latest changes. Could you please review again when you get a chance. |
|
@pranjalpatidar01 The distro handling and overall script structure do not align with the repository conventions for platform-specific scripts. it should ideally be scoped to the intended target platform instead of handling multiple Ubuntu, RHEL, and SLES variants in the script Please refer to the existing scripts in the repository and restructure this script accordingly. |
|
Hi @sankalp-sde , I’ve simplified the pandas build script structure and removed the multi-distro handling so that the script is now scoped specifically for UBI/RHEL 9.6 and aligned with the existing repository conventions. Could you please review again when you get a chance. |
|
Hi @sankalp-sde , |
|
Hi @sankalp-sde,
The CI issue has been addressed in commit 401c9f2. The workflow is
currently awaiting maintainer approval before it can run again.
Could you please approve or rerun the workflow when you get a chance?
Thank you.
…On Wed, 27 May 2026 at 15:52, Sankalp ***@***.***> wrote:
*sankalp-sde* left a comment (linux-on-ibm-z/build-scripts#84)
<#84 (comment)>
@pranjalpatidar01 <https://github.com/pranjalpatidar01> The distro
handling and overall script structure do not align with the repository
conventions for platform-specific scripts. it should ideally be scoped to
the intended target platform instead of handling multiple Ubuntu, RHEL, and
SLES variants in the script
Please refer to the existing scripts in the repository and restructure
this script accordingly.
—
Reply to this email directly, view it on GitHub
<#84?email_source=notifications&email_token=BFE6L35IR6TG5IZYZPSBMBD4426U7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJVGM3DINZXGY3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4553647766>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFE6L32HT7CE6DJCCJQ7UZD4426U7AVCNFSM6AAAAACZNLXYVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKNJTGY2DONZWGY>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BFE6L36M2EMAFSC65ZPKKYT4426U7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJVGM3DINZXGY3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BFE6L3ZZEEA3TFRUGM5C2A34426U7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJVGM3DINZXGY3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@pranjalpatidar01 Please take a look at the review comments and make the necessary changes |
|
Hi @sankalp-sde, I reviewed the comments. The package version comment has already been addressed, and the file is currently named Could you please take another look when you get a chance? Thank you. |
| # ---------------------------------------------------------------------------- | ||
|
|
||
| PACKAGE_NAME=pandas | ||
| PACKAGE_VERSION=2.2.3 |
There was a problem hiding this comment.
Please use the standard parameterized format for PACKAGE_VERSION to maintain consistency with existing build scripts and support version overrides via script arguments:
PACKAGE_VERSION=${1:-v2.2.3}
| "maintainer": "Pranjal", | ||
| "package_name": "pandas", | ||
| "github_url": "https://github.com/pandas-dev/pandas", | ||
| "version": "2.2.3", |
There was a problem hiding this comment.
Update the version field to align with the repository tag format - v2.2.3
| # ---------------------------------------------------------------------------- | ||
| # | ||
| # Package : pandas | ||
| # Version : 2.2.3 |
There was a problem hiding this comment.
Update the version field to align with the repository tag format - v2.2.3
|
Addressed the review comments:
|
|
Fixed!
…On Wed, 10 Jun 2026 at 15:11, Sankalp ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In p/pandas/pandas_ubi_9.6.sh
<#84 (comment)>
:
> +# Tested on : UBI:9.6
+# Language : Python
+# Ci-Check : True
+# Script License : Apache License, Version 2 or later
+# Maintainer : Pranjal
+#
+# Disclaimer: This script has been tested in root mode on given
+# ========== platform using the mentioned version of the package.
+# It may not work as expected with newer versions of the
+# package and/or distribution. In such case, please
+# contact "Maintainer" of this script.
+#
+# ----------------------------------------------------------------------------
+
+PACKAGE_NAME=pandas
+PACKAGE_VERSION=2.2.3
Please use the standard parameterized format for PACKAGE_VERSION to
maintain consistency with existing build scripts and support version
overrides via script arguments:
PACKAGE_VERSION=${1:-v2.2.3}
------------------------------
In p/pandas/build_info.json
<#84 (comment)>
:
> @@ -0,0 +1,16 @@
+{
+ "maintainer": "Pranjal",
+ "package_name": "pandas",
+ "github_url": "https://github.com/pandas-dev/pandas",
+ "version": "2.2.3",
Update the version field to align with the repository tag format - v2.2.3
------------------------------
In p/pandas/pandas_ubi_9.6.sh
<#84 (comment)>
:
> @@ -0,0 +1,86 @@
+#!/bin/bash -e
+# ----------------------------------------------------------------------------
+#
+# Package : pandas
+# Version : 2.2.3
Update the version field to align with the repository tag format - v2.2.3
—
Reply to this email directly, view it on GitHub
<#84?email_source=notifications&email_token=BFE6L35GP26ZMTXACRWVXZ347EUMNA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMZXGE4DCNZUGYY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-4371817461>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFE6L3Y2X5T3AZHKL76JZDD47EUMNAVCNFSNUABFKJSXA33TNF2G64TZHM4TMNZUGM3DCNBSHNEXG43VMU5TINJSGMYTMNRRHAZKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BFE6L3ZU42UPXDSQ6V5GQXT47EUMNA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMZXGE4DCNZUGYY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BFE6L353XFWLSSOYLCFTU6L47EUMNA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMZXGE4DCNZUGYY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Summary
Added build script support for pandas 2.2.3.
Included files
Validation