Fix sentencepiece v2#86
Open
purvakale2904 wants to merge 2 commits into
Open
Conversation
purvakale2904
commented
May 27, 2026
purvakale2904
commented
Contributor
- Remove sudo from make install (CI runs as root)
- cd to python subdirectory before running pytest
- Add wheel file existence validation
- Add LD_LIBRARY_PATH export
- Remove unnecessary subshells
Contributor
|
@purvakale2904 Please rebase with the latest main and resolve the conflicts. |
purvakale2904
force-pushed
the
fix-sentencepiece-v2
branch
from
3c89ade to
b13b34d
Compare
Contributor
Author
|
Hi Sankalp, rebased with latest main and resolved the conflicts. Please have a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.