[sos-spyre] collect spyre users podman disk free details by sahithiRavindranath · Pull Request #38 · linux-ras/ServiceReport

sahithiRavindranath · 2026-02-17T08:20:07Z

issue:
podman disk free data was not collected for non root users.

solution:
collecting the podman disk free data for all non root spyre users(part of sentient group)

sos-plugin/spyre-external.py

sourabhjains · 2026-02-17T09:53:41Z

sos-plugin/spyre-external.py

+                for user in users:
+                    # since root user outputs are collected in podman plugin
+                    # skipping here
+                    if not user or user == 'root':


User may not have updated podman plugin that collect podman system df [-v]. So the above assumption may not hold true for all user.

So run this for root user always.

removed root exception.

sourabhjains · 2026-02-17T09:55:23Z

sos-plugin/spyre-external.py

+                # get unique list of users
+                users = list(set(users))
+
+                for user in users:


Move the code to find non-root users of sentient group to a helper function.

sourabhjains · 2026-02-17T12:24:56Z

sos-plugin/spyre-external.py

        return spyre_cards_bus_ids

+    def get_spyre_usernames(self):
+


What is this newline for?

Please use static Linters to find basic issue in the code. I recommend pylint.

sos-plugin/spyre-external.py

sourabhjains · 2026-02-17T12:38:20Z

sos-plugin/spyre-external.py

+        groupname = "sentient"
+        spyre_users = self.exec_cmd("getent group "+ groupname)
+        if spyre_users['status'] == 0 and spyre_users['output'].strip():
+


Why we have an empty new line just after if condition?

sourabhjains · 2026-02-17T12:40:07Z

sos-plugin/spyre-external.py

+
+        users = []
+        # All spyre users must be part of sentient group
+        groupname = "sentient"


I don't think we really need groupname variable. It is only used at one place.

sourabhjains · 2026-02-17T12:49:20Z

sos-plugin/spyre-external.py


+    def get_spyre_usernames(self):
+
+        users = []


We have two list variables in this function users and spyre_users.

The function scoped list variable should be named as spyre_users and while extracting the users from output lines users name can be used.

sourabhjains · 2026-02-17T12:55:36Z

sos-plugin/spyre-external.py

+                            if u.strip()
+                        ]
+                # get unique list of users
+                users = list(set(users))


You are making this function unnecessarily complicated. It is not only very inefficient but also hard to review.

How about keeping things simple:

"""
get_spyre_username(): Get the names of users belonging to
the sentient group.

Currently, all users belonging to the sentient group are
considered Spyre card users.

Args:
None

Returns:
List of spyre card users
"""
def get_spyre_username():
spyre_users = []
getent_cmd_output = self.exec_cmd("getent group sentient")

# Multiple lines are not expected but trying to be safe for line in getent_cmd_output.splitlines(): line = line.strip().split(':') # Expected line format # group_name:x:group_id:user1,user2 # No user at this line if len(line) < 4: continue for user in line[3].split(','): if user not in sentinet_users: sentient_users.add(user)

return sentient_users

sos-plugin/spyre-external.py

Previously, podman disk usage data was collected only for the root user. This fix collects the podman disk usage for all non root spyre users(part of sentient group) as well. Signed-off-by: Sahithi Ravindranath <Sahithi.Ravindranath@ibm.com>

sourabhjains · 2026-02-18T08:15:25Z

sos-plugin/spyre-external.py

        ])

+        sentient_users = self.get_spyre_users()
+        print(sentient_users)


Did you forget to remove debug prints?

sourabhjains · 2026-02-18T10:09:47Z

sos-plugin/spyre-external.py

            "/etc/security/limits.d/memlock.conf",
        ])

+        sentient_users = self.get_spyre_users()


This variable name should be spyre_users.

sourabhjains · 2026-02-18T10:11:00Z

sos-plugin/spyre-external.py


+        sentient_users = self.get_spyre_users()
+        print(sentient_users)
+        for user in sentient_users:


What if root is not part of sentient group?

We should always run these commands for root user regardless.

sourabhjains reviewed Feb 17, 2026

View reviewed changes

sahithiRavindranath force-pushed the sos-spyre branch from a45ab56 to 42e5002 Compare February 17, 2026 10:28

sourabhjains reviewed Feb 17, 2026

View reviewed changes

sos-plugin/spyre-external.py Show resolved Hide resolved

sahithiRavindranath force-pushed the sos-spyre branch from 42e5002 to 3d6143d Compare February 18, 2026 05:19

sourabhjains reviewed Feb 18, 2026

View reviewed changes

Conversation

sahithiRavindranath commented Feb 17, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sahithiRavindranath Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

sahithiRavindranath Feb 17, 2026 •

edited

Loading