ci: ansible-lint requires dependencies to be installed [citest_skip]

[richm]

ansible-lint requires the dependencies in meta/collection-requirements.yml
and tests/collection-requirements.yml to be installed. tox-lsr 3.18.1
will ensure they are installed.

Refactor the tests somewhat so that the collection and test steps are separate.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use the newer tox-lsr version and separate collection conversion from ansible lint/test execution.

CI:

• Bump tox-lsr used in GitHub Actions workflows from 3.18.0 to 3.18.1.
• Refine ansible-lint and ansible-test workflows to run collection conversion and test steps as separate jobs.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.18.1 so ansible-lint and ansible-test dependencies are installed correctly, and refactors ansible-lint and ansible-test jobs to run collection conversion and lint/test steps separately.

Sequence diagram for updated ansible-lint GitHub Actions job

sequenceDiagram
  participant GitHubActions
  participant Job_ansible_lint as Job_ansible_lint
  participant Pip as pip3
  participant Tox
  participant ToxLsr as tox_lsr_3_18_1
  participant AnsibleLintEnv as ansible_lint_collection_env

  GitHubActions->>Job_ansible_lint: Start job matrix
  Job_ansible_lint->>Pip: install tox_lsr_3_18_1 from GitHub
  Pip-->>Job_ansible_lint: tox_lsr_3_18_1 installed

  Job_ansible_lint->>GitHubActions: setup_python with matrix versions
  GitHubActions-->>Job_ansible_lint: python ready

  Job_ansible_lint->>Tox: run env collection
  Tox->>ToxLsr: prepare collection structure
  ToxLsr-->>Tox: collection conversion complete
  Tox-->>Job_ansible_lint: collection conversion done

  Job_ansible_lint->>Tox: run env ansible_lint_collection with LSR_ANSIBLE_LINT_DEP and LSR_ANSIBLE_LINT_ANSIBLE_DEP
  Tox->>AnsibleLintEnv: create and run
  AnsibleLintEnv-->>Tox: ansible_lint results
  Tox-->>Job_ansible_lint: job status
  Job_ansible_lint-->>GitHubActions: publish ansible_lint outcome

Loading

File-Level Changes

Change	Details	Files
Bump tox-lsr to 3.18.1 across GitHub workflows to ensure collection requirements are installed for ansible-lint and tests.	Update pip installation of tox-lsr from version 3.18.0 to 3.18.1 in ansible-lint workflow. Update pip installation of tox-lsr from version 3.18.0 to 3.18.1 in ansible-test workflow. Update pip installation of tox-lsr from version 3.18.0 to 3.18.1 in ansible-managed-var-comment workflow. Update pip installation of tox-lsr from version 3.18.0 to 3.18.1 in qemu-kvm-integration-tests workflow.	.github/workflows/ansible-lint.yml .github/workflows/ansible-test.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/qemu-kvm-integration-tests.yml
Refactor ansible-lint workflow to split collection build and linting into separate tox invocations.	Add dedicated step that runs 'tox -e collection' to perform role-to-collection conversion. Change ansible-lint step to only run the ansible-lint collection environment instead of both collection and ansible-lint in one tox invocation, keeping environment variable wiring intact.	.github/workflows/ansible-lint.yml
Refactor ansible-test workflow to split collection build and ansible-test execution into separate tox invocations.	Add dedicated step that runs 'tox -e collection' before tests to perform role-to-collection conversion. Change ansible-test step to only run the ansible-test collection environment, removing the collection environment from the same tox command while preserving dynamic basepython override.	.github/workflows/ansible-test.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}