fix: hide color tool in effect (blur/mosaic) mode#817
Merged
lzwind merged 1 commit intolinuxdeepin:masterfrom Apr 11, 2026
Merged
fix: hide color tool in effect (blur/mosaic) mode#817lzwind merged 1 commit intolinuxdeepin:masterfrom
lzwind merged 1 commit intolinuxdeepin:masterfrom
Conversation
Commit 81701e0 added m_colorTool->show() to the else branch of changeShotToolWidget, which is shared by all non-geometry tools. This overrides the earlier m_colorTool->setFunction("effect") call that correctly hides it, causing the color picker to appear in blur, mosaic, shape-blur and pen-blur modes where it is not needed. Add a dedicated branch for "effect" that keeps m_colorTool hidden. bug: https://pms.uniontech.com/bug-view-356071.html
lzwind
approved these changes
Apr 11, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 81701e0 added m_colorTool->show() to the else branch of changeShotToolWidget, which is shared by all non-geometry tools. This overrides the earlier m_colorTool->setFunction("effect") call that correctly hides it, causing the color picker to appear in blur, mosaic, shape-blur and pen-blur modes where it is not needed.
Add a dedicated branch for "effect" that keeps m_colorTool hidden.
bug: https://pms.uniontech.com/bug-view-356071.html