fix(system): Fix Cancelable flag error for check_system job on failure#361
Open
electricface wants to merge 1 commit intolinuxdeepin:develop/intranet-updatefrom
Open
fix(system): Fix Cancelable flag error for check_system job on failure#361electricface wants to merge 1 commit intolinuxdeepin:develop/intranet-updatefrom
electricface wants to merge 1 commit intolinuxdeepin:develop/intranet-updatefrom
Conversation
failure The bug occurred because Function.atEnd() incorrectly reported Cancelable=false in failure scenarios, leaving a failed check_system job in an abnormal terminal state, which further misled systemOnChanging to remain true Bug: https://pms.uniontech.com/bug-view-356225.html Change-Id: I1ce2221f29d12291c08cf7f6d30e8af4fa027287
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: electricface The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug occurred because Function.atEnd() incorrectly
reported Cancelable=false in failure scenarios, leaving a failed
check_system job in an abnormal terminal state, which further misled
systemOnChanging to remain true
Bug: https://pms.uniontech.com/bug-view-356225.html
Change-Id: I1ce2221f29d12291c08cf7f6d30e8af4fa027287