Conversation
…erarchy writer now includes "writer from parent or writer from child" alongside the existing direct/owner/global_org_admin grants, mirroring the auditor relation's existing bidirectional traversal. An editor on any organization in a connected parent-child-sibling group becomes an editor on every member of that group. Bumps the model to v14.3.1 and documents the new inheritance in PERMISSIONS.md. Verified against a local OpenFGA instance: writer access on one org in a three-level test hierarchy correctly cascaded to parent, sibling, and grandchild orgs, with no effect on unrelated orgs. Jira: LFXV2-3029 Link: https://linuxfoundation.atlassian.net/browse/LFXV2-3029 Signed-off-by: Prabodh Chaudhari <pchaudhari@linuxfoundation.org> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
There was a problem hiding this comment.
Pull request overview
Extends B2B organization writer access transitively across parent-child hierarchies.
Changes:
- Adds bidirectional writer inheritance.
- Bumps the OpenFGA model to v14.3.1.
- Regenerates permissions documentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
PERMISSIONS.md |
Documents writer inheritance. |
charts/lfx-platform/templates/openfga/model.yaml |
Bumps the model version. |
charts/lfx-platform/files/model.fga |
Adds parent/child writer traversal. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
writerrelation onb2b_orgnow cascades transitively up and down the parent/child hierarchy, mirroring the existingauditortraversal. Part of LFXV2-3029.Change
An editor on any organization in a connected parent-child-sibling group becomes an editor on every member of that group. Model bumped to v14.3.1;
PERMISSIONS.mdregenerated to document the new inheritance.Verification
Verified against a local OpenFGA instance: writer access on one org in a three-level test hierarchy correctly cascaded to parent, sibling, and grandchild orgs, with no effect on unrelated orgs. No indexer/publisher changes are required —
member-servicealready publishes bothparentandchildtuples today (needed for the existingauditorcascade).Related
Consumed by the BFF-side change in lfx-self-serve#2216.
Jira: LFXV2-3029
Link: https://linuxfoundation.atlassian.net/browse/LFXV2-3029
Status
Draft — coordinating merge order with lfx-self-serve#2216 and pending remaining e2e coverage there.
Made with Cursor