Require confirmation for custom OpenAI-compatible endpoints#264
Draft
leoz9 wants to merge 1 commit into
Draft
Conversation
leoz9
changed the title
leoz9
force-pushed
the
codex/warn-custom-base-url
branch
from
fea71ea to
dc67420
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_url.Why
This strengthens the mitigation discussed in #253: a custom OpenAI-compatible endpoint receives the configured API key during connection tests and generation. The UI now makes that trust decision explicit before using an untrusted endpoint.
Validation
uv run pytest app/services/llm/test_openai_compat_unittest.py -quv run python -m json.tool webui/i18n/zh.json >/dev/null && uv run python -m json.tool webui/i18n/en.json >/dev/nulluv run pytest tests/test_generate_script_docu_unittest.py -qRefs #253