Skip to content

Add lipscore product attributes 1.x#34

Open
AdamLipscore wants to merge 2 commits into
main-1.xfrom
ratings-import-1.x
Open

Add lipscore product attributes 1.x#34
AdamLipscore wants to merge 2 commits into
main-1.xfrom
ratings-import-1.x

Conversation

@AdamLipscore

Copy link
Copy Markdown
Contributor

Add product attributes for ratings
Add cron and console command for import

@ivanovaolga ivanovaolga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! I have just some comments on protected/public stuff

Comment thread Model/Action/ImportRatings.php Outdated
Comment thread Model/Action/ImportRatings.php Outdated
Comment thread Model/Action/ImportRatings.php Outdated
return $this->parseApiResponse($apiData);
}

public function parseApiResponse($response)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be protected? it doesn't used outside this class

Comment thread Model/Action/ImportRatings.php Outdated
Comment thread Setup/Patch/Data/AddProductAttributes.php
Comment thread Model/Action/ImportRatings.php Outdated
Add cron and console command for import rating data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants