Fix localStorage setPreference error on modern browsers#2
Open
HackerWand wants to merge 1 commit into
Open
Conversation
Modern browsers (e.g. Chrome 120+) enforce `localStorage.length` as a read-only property with only a getter.
However, the DevTools frontend occasionally attempts to call `setPreference('length', ...)` during settings migration, causing a TypeError: "Cannot set property length of #<Storage> which has only a getter".
This change skips setting `localStorage['length']` in `InspectorFrontendHostStub.setPreference`, since `length` is automatically managed by the browser and should never be written manually.
Fixes remote debugging crash in tools like Chii when used with up-to-date browsers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern browsers (e.g. Chrome 120+) enforce
localStorage.lengthas a read-only property with only a getter. However, the DevTools frontend occasionally attempts to callsetPreference('length', ...)during settings migration, causing a TypeError: "Cannot set property length of # which has only a getter".This change skips setting
localStorage['length']inInspectorFrontendHostStub.setPreference, sincelengthis automatically managed by the browser and should never be written manually.Fixes remote debugging crash in tools like Chii when used with up-to-date browsers.