Sharpen Tiny Stories project profile for technical review - #22
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1dc1378b3c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| consequences, and people. Reviewer mode owns judge rows and sanitized | ||
| telemetry; raw prompts, provider payloads, and private reasoning stay out. | ||
|
|
||
| ## Reviewer Path |
There was a problem hiding this comment.
Keep the README anchor compatible with public links
Renaming this heading changes GitHub's generated anchor from #reviewer-run to #reviewer-path, but the deployed landing page still links to https://github.com/lishehao/RPG_Demo#reviewer-run in docs/index.html (I found three occurrences with repo-wide search). In the public reviewer flow, those “Reviewer run guide” links will now land at the top of the repository instead of the reviewer instructions, so either keep a compatible Reviewer Run anchor or update the landing-page links/tests together.
Useful? React with 👍 / 👎.
| For a configured live backend: | ||
|
|
||
| ```bash | ||
| python3 tools/http_product_smoke.py --base-url http://127.0.0.1:8000 |
There was a problem hiding this comment.
Document the authoring-disabled smoke path
For production-like backends with APP_PUBLIC_DEMO_AUTHORING_ENABLED=false, the default smoke command below still tries to create a template via POST /narrative/templates, which rpg_backend/main.py blocks when authoring is disabled. I checked python3 tools/http_product_smoke.py --help, and --use-first-public-template is the supported mode to “skip template creation” when authoring is disabled; removing that documented command makes the live-backend verification path fail before it reaches Play in that context.
Useful? React with 👍 / 👎.
| Before citing a deployed route as application evidence, run: | ||
|
|
||
| ```bash | ||
| python3 tools/portfolio_public_evidence_preflight.py | ||
| ``` | ||
|
|
||
| Each turn follows the same control pattern: | ||
| This checks whether the public branch and GitHub Pages deployment actually | ||
| contain the evidence being referenced. |
There was a problem hiding this comment.
Keep the public check scoped to repo evidence too
Narrowing the gate to “a deployed route” drops the repository/docs case even though the same preflight is meant to protect README.md, docs/, and other evidence-sensitive paths from being cited before they are pushed. In the scenario where a reviewer is sent the GitHub repo or evidence packet rather than a Pages route while local HEAD is ahead of origin/main, this wording no longer tells the sender to run the check, so reviewers can be pointed at evidence they cannot see publicly.
Useful? React with 👍 / 👎.
What changed
Why
The previous README repeated the demo and reviewer instructions while burying the strongest R&D evidence. The new structure makes the product question, engineering contribution, evaluation protocol, known latency risk, and reviewer path legible in the first few minutes.
Validation
The existing Vite large-chunk warning remains unchanged.