Skip to content

fix: prevent ghost changes when SSL data is empty or invalid #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manganate006 wants to merge 1 commit into from
Closed

fix: prevent ghost changes when SSL data is empty or invalid #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/server/routes/domain-updater/updateFns/ssl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,11 @@ export async function updateSSL(
newVal = normalizeStr(newVal);
}


// Skip if both values are empty (no real change)
if (!oldVal && !newVal) {
continue;
}

// Special date comparison, because timezones are stupid
if (field.type === 'date') {
const oldDate = new Date(oldVal);
Expand All @@ -83,6 +87,12 @@ export async function updateSSL(
const diffInMs = Math.abs(newDate.getTime() - oldDate.getTime());
const diffInDays = diffInMs / (1000 * 60 * 60 * 24);

// Skip if new value is invalid/empty (NaN means we couldn't parse the new date)
// This prevents ghost changes when SSL fetch fails
if (isNaN(diffInDays) && !newVal) {
continue;
}

if (isNaN(diffInDays) || diffInDays > 1) {
updateSet.push(`${field.column} = $${updateSet.length + 2}::date`);
updateValues.push(toDateOnly(newVal));
Expand All @@ -92,6 +102,11 @@ export async function updateSSL(
}

if (oldVal !== newVal && field.type != 'date') {
// Skip recording if new value is empty (likely a fetch failure, not a real change)
if (!newVal && oldVal) {
continue;
}

updateSet.push(`${field.column} = $${updateSet.length + 2}::${field.type}`);
updateValues.push(field.new ?? null);

Expand Down