docs(for-developer): overhaul — grouped by domain (contracts / API / SDK / overview)#10
Open
tyler-tsai wants to merge 4 commits into
Open
docs(for-developer): overhaul — grouped by domain (contracts / API / SDK / overview)#10tyler-tsai wants to merge 4 commits into
tyler-tsai wants to merge 4 commits into
Conversation
tyler-tsai
force-pushed
the
docs/for-developer-p0
branch
from
4e805dd to
8070473
Compare
tyler-tsai
changed the title
tyler-tsai
force-pushed
the
docs/for-developer-p0
branch
from
8070473 to
29ac46a
Compare
…isBNBx, Credit, Lending, Oracle) All contract-derived pages, for contract-team review: - CDP mechanics: no interest at borrow, dynamic AMO duty clamped to maxDuty (~200% APY)/minDuty, Abacus auction curves, borrowed() +100 wei - V3 DEX README + mechanics: Uniswap V3 fork; fee tiers 0.05/0.30/1.00%; Lista-specific pool init-code hash for off-chain address derivation - slisBNB smart-contract: fix 2 stale OFT addresses (+ StakeHub/GovBNB) - slisBNBx delegation: changeable per-account via SlisBNBxMinter.delegateAllTo - Credit loan-lifecycle: penalty 15%; correct supplyAndBorrow signature - Lending: contract-reference, events & onMoolah* callbacks, Adaptive Curve IRM, Smart Lending/StableSwap integration (+ README contents) - Multi-Oracle: consuming-prices (peek USD vs Moolah getPrice 10**(36+loanDec-collDec) scale, raw-unit conversion) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ntions Moolah Lending REST API pages, for backend review: - overall/vault/market/position-liquidation-emission rewritten to match the live NestJS controllers: string chain (not numeric chainId), sort/order; real endpoints; order required on /borrow/markets; totalBorrow history is protocol-wide; exact emission signature-message format - new API Conventions page (response envelope, chain, pagination, signature-gated endpoints, caching) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
New canonical @lista-dao/moolah-lending-sdk + moolah-sdk-core page: install, MoolahSDK init, read methods, StepParam[] builder pattern, simulation, Decimal utility, MoolahApiClient. (Re-export scope: lending SDK re-exports a curated subset; simulate fns/ABIs come from sdk-core.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- overview.md: rewritten from the legacy Helio-era narrative into a product map + audience routing + networks - SUMMARY.md: navigation entries for all new/updated for-developer pages Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tyler-tsai
force-pushed
the
docs/for-developer-p0
branch
from
29ac46a to
3a61bb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for-developeroverhaul — commits grouped by domainOrganized into 4 commits by reviewer domain — review the commit that matches your area:
lista-api)overall/vault/market/position-liquidation-emission+conventionssdk.mdoverview.md+SUMMARY.mdPer-page review checkpoints + source repos:
utils/P0_REVIEW_ROUTING.md.What this does
Rewrites the stale Overview, fills the two biggest gaps (SDK, V3 DEX), corrects factual errors found by diffing docs against source, and adds the missing contract-reference + integration layer for Lending and Oracle. Independently reviewed by Codex (0 confidentiality leaks / broken links / formatting issues); every technical claim verified against the contract / API / SDK source.
Key factual fixes
jug.drip(none at borrow time); rate clamped tomaxDuty≈ 200% APY (was "20%"); real Abacus auction curves.chain(not numericchainId),sort/order;orderrequired on/borrow/markets; fictional endpoints replaced with real routes.peek()USD price vs MoolahgetPrice()with the10**(36+loanDec−collDec)scale — the two were conflated.delegateAllTo. Credit: penalty 15% (not 3%).Out-of-scope follow-ups (not in this PR)
lista-api/borrow/marketshas no default fororder→ 500 if omitted. Documented as required; backend may want to add a= 'desc'default.introduction/).Auto-sync
No auto-synced address tables touched. The slisBNB smart-contract page is hand-maintained (not a sync target), confirmed against
contract-page-map.json/gen-contract-map.mjs.🤖 Generated with Claude Code