Skip to content
This repository was archived by the owner on Sep 30, 2019. It is now read-only.

Dynamo config - #114

Merged
cbaron merged 13 commits into
little-bear-labs:masterfrom
cbaron:dynamo-config
Jun 24, 2019
Merged

Dynamo config#114
cbaron merged 13 commits into
little-bear-labs:masterfrom
cbaron:dynamo-config

Conversation

@cbaron

@cbaron cbaron commented May 1, 2019

Copy link
Copy Markdown
Contributor

While the plan is to do an emulator rewrite, I have a need to run an instance of the appsync emulator on a device which connects to a dynamo instance residing on aws.

This PR implements logic to merge a default configuration with a user submitted custom configuration DynamoDB to be used by the AppSync emulator.

Will follow up with tests.

@bboure

bboure commented May 1, 2019

Copy link
Copy Markdown
Contributor

👍 #83 is old and abandoned, but this PR seems related.
Maybe we could include this in this PR?
For example, if DynamoDb is false, in the input file, it would just disable it?

@cbaron

cbaron commented May 1, 2019

Copy link
Copy Markdown
Contributor Author

@bboure -- I would be glad to incorporate #83 . Thanks for the reminder.

@cbaron
cbaron requested review from bboure and lightsofapollo June 23, 2019 15:39
@cbaron cbaron changed the title WIP: Dynamo config Dynamo config Jun 23, 2019
@cbaron

cbaron commented Jun 23, 2019

Copy link
Copy Markdown
Contributor Author

@bboure @lightsofapollo -- after trying this out I need to add more tests for bin/server

@cbaron cbaron changed the title Dynamo config WIP: Dynamo config Jun 23, 2019

@lightsofapollo lightsofapollo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbaron cbaron changed the title WIP: Dynamo config Dynamo config Jun 24, 2019
@cbaron
cbaron merged commit 03a2b20 into little-bear-labs:master Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants