This repository was archived by the owner on Sep 30, 2019. It is now read-only.
[111] AppSync Emulator - implement toDynamoDBFilterExpression - #133
Open
asodeur wants to merge 3 commits into
Open
[111] AppSync Emulator - implement toDynamoDBFilterExpression#133asodeur wants to merge 3 commits into
asodeur wants to merge 3 commits into
Conversation
Contributor
|
@asodeur Thank you again for the follow up~ Please mark us for review so we can review your work ASAP in future :) We love contributions but only see them pop up when you open the PR and then flag us for review. |
Contributor
|
@asodeur As with the other PRs I'd love at least one test that validates the success case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial attempt at $util.transform.toDynamoDBFilterExpression (see #111).
Not sure this already should return string. Filter expressions can contain comparison operators (
<>, ...) that get escaped somewhere in VTL. I am wrapping the whole result innew String(...)which seems to hide the filter expression from VTL but feels like a dirty hack.I will not find the time to write tests for this any time soon, sorry.