Skip to content
This repository was archived by the owner on Sep 30, 2019. It is now read-only.

Refactor $utils.map functions - #77

Open
marklawlor wants to merge 1 commit into
little-bear-labs:masterfrom
marklawlor:fix_util_map
Open

Refactor $utils.map functions#77
marklawlor wants to merge 1 commit into
little-bear-labs:masterfrom
marklawlor:fix_util_map

Conversation

@marklawlor

Copy link
Copy Markdown
Contributor

This is an untested PR to fix #70

I'm working on an unrelated project today, but I'll test this over the weekend

@marklawlor

Copy link
Copy Markdown
Contributor Author

So the test's are failing as they are testing with an object and not a JavaMap. Quick glance at the code base, there are number of other places where an object is returned instead of JavaMap.

@cbaron @lightsofapollo I'm assuming all the vtl operations should be using a JavaMap? Or am I missing something. I'm not sure what the fallout would be if everything was converted to a JavaMap

@lightsofapollo

Copy link
Copy Markdown
Contributor

@marklawlor afaik returning an object is a bug and everything should be a java map (otherwise operations that work in aws appsync context will fail here)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants