Fix all TS errors#810
Open
zorgjbe wants to merge 7 commits intolittlesera:devfrom
Open
Conversation
- cast around the ActivityName/LSCGActivityName hook types - swap .indexOf for .includes - remove unnecessary `!!`s - make sure all items grabbed from `InventoryGet` are checked
Instead, pass down the data and metadata from the about-to-be-sent message, and update all handlers to either let the message out, or skip altogether. This lets all said handler skip having to do another round of message extraction as well.
Contributor
Author
|
This was all in search of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings down all of the TS errors to 0. Completely untested, but most of those are just twiddling types or adding casts.
The more intrusive one would be Cleanup the CustomAction interface so we don't pass down hook handlers 'cause I didn't like passing down those hook
next,argspairs down all over the place.