build(deps): upgrade Storybook to 10.6.0 - #1757
Closed
jpyzio123 wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The direct Chromatic CLI and CI action still predate Storybook 10 support.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Upgrades Storybook and related tooling while moving development and CI to Node.js 22.13.0.
Changes:
- Upgrades Storybook, addons, and Testing Library dependencies.
- Migrates Storybook configuration to ESM resolution and pre-optimizes fake timers.
- Updates CI runtimes and refreshes the dependency lockfile.
File summaries
| File | Description |
|---|---|
package.json |
Updates Storybook linting and Node.js version. |
package-lock.json |
Locks the upgraded dependency graph and security fixes. |
packages/react-components/package.json |
Upgrades Storybook, addons, and testing packages. |
packages/react-components/.storybook/main.ts |
Adds ESM package resolution and fake-timer optimization. |
.github/workflows/tests.yml |
Configures Node.js 22.13.0 for tests. |
.github/workflows/chromatic.yml |
Configures Node.js 22.13.0 for Chromatic. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
To be re-checked and merged after packages are old enough to be safe
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This resolves Dependabot alerts #504 (GHSA-82fw-gwwq-j7x9) and #496 (GHSA-w9m9-85wc-3x92) as part of AC-4477.
The lockfile diff is large because Storybook 10 replaces and re-hoists a substantial part of the Storybook/Vite dependency graph, including platform-specific Oxc packages.
Verification