Skip to content

fix the RPC tests #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xianshijing-lk merged 1 commit into from
Apr 14, 2026
Merged

fix the RPC tests #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/tests/integration/test_media_multistream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,16 @@ void MediaMultiStreamIntegrationTest::runPublishTwoVideoAndTwoAudioTracks(
}

for (const auto &track : video_tracks) {
sender_room->localParticipant()->unpublishTrack(track->sid());
if (track->publication()) {
sender_room->localParticipant()->unpublishTrack(
track->publication()->sid());
}
}
for (const auto &track : audio_tracks) {
sender_room->localParticipant()->unpublishTrack(track->sid());
if (track->publication()) {
sender_room->localParticipant()->unpublishTrack(
track->publication()->sid());
}
}
}

Expand Down
21 changes: 18 additions & 3 deletions src/tests/stress/test_latency_measurement.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,19 @@ TEST_F(LatencyMeasurementTest, ConnectionTime) {
double latency_ms =
std::chrono::duration<double, std::milli>(end - start).count();
stats.addMeasurement(latency_ms);

// Get room and participant session IDs for debugging
auto room_info = room->room_info();
std::string room_sid =
room_info.sid.has_value() ? room_info.sid.value() : "unknown";
std::string participant_sid = room->localParticipant()
? room->localParticipant()->sid()
: "unknown";

std::cout << " Iteration " << (i + 1) << ": " << std::fixed
<< std::setprecision(2) << latency_ms << " ms" << std::endl;
<< std::setprecision(2) << latency_ms << " ms"
<< " | participant_sid=" << participant_sid
<< " | room_sid=" << room_sid << std::endl;

} else {
std::cout << " Iteration " << (i + 1) << ": FAILED to connect"
Expand Down Expand Up @@ -841,8 +852,12 @@ TEST_F(LatencyMeasurementTest, FullDeplexAudioLatency) {
std::cout << "Response timeouts: " << timeouts << std::endl;
}

room_a->localParticipant()->unpublishTrack(track_a->sid());
room_b->localParticipant()->unpublishTrack(track_b->sid());
if (track_a->publication()) {
room_a->localParticipant()->unpublishTrack(track_a->publication()->sid());
}
if (track_b->publication()) {
room_b->localParticipant()->unpublishTrack(track_b->publication()->sid());
}

EXPECT_GT(round_trip_stats.count(), 0)
<< "At least one round-trip latency measurement should be recorded";
Expand Down
Loading