Export native audio configuration types from public API#1022
Open
spydon wants to merge 2 commits intolivekit:mainfrom
Open
Export native audio configuration types from public API#1022spydon wants to merge 2 commits intolivekit:mainfrom
spydon wants to merge 2 commits intolivekit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
onConfigureNativeAudiocallback is the intended way to customize iOS/Android audio session configuration, but the types needed to use it (NativeAudioConfiguration,AppleAudioCategory,AppleAudioCategoryOption,AppleAudioMode,AudioTrackState, etc.) are not exported from the public API.This forces consumers to import from
src/paths, triggeringimplementation_importslint warnings.This PR adds two exports to
livekit_client.dart:src/support/native_audio.dart—NativeAudioConfiguration,AppleAudioCategory,AppleAudioCategoryOption,AppleAudioModeand their extensionssrc/track/audio_management.dart—AudioTrackState,ConfigureNativeAudioFunc,NativeAudioManagement,audioTrackState,onConfigureNativeAudio(internal mixins are excluded viashow)Use case
We need to configure the iOS audio session with
mixWithOthers+voiceChatmode for our voice AI app. The only way to do this is viaonConfigureNativeAudio, which requires these types.