Skip to content

Add bun runtime tests#607

Open
lukasIO wants to merge 5 commits intomainfrom
lukas/runtime-tests
Open

Add bun runtime tests#607
lukasIO wants to merge 5 commits intomainfrom
lukas/runtime-tests

Conversation

@lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Feb 4, 2026

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2026

⚠️ No Changeset found

Latest commit: cdb103a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasIO lukasIO changed the title Add bun and deno runtime tests Add bun runtime tests Feb 4, 2026
Comment on lines 204 to 207

it.concurrent(
it(
'connects to a room',
async () => {
Copy link
Contributor

@1egoman 1egoman Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(if-minor): I am assuming these were removed becaue bun doesn't support it.concurrent. Does removing these slow down the e2e tests significantly? And if so, is it worth trying to make these conditionally concurrent depending on if the test runner supports it.concurrent or not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, I had this initially and removed it as it seemed less elegant than just removing the concurrent version but in the long run it might pay off to make the change now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants