Skip to content

Make sure memory usage is not undercounted #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milos-lk merged 1 commit into from
Jan 30, 2026
Merged

Make sure memory usage is not undercounted #1394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions utils/hwstats/cpu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@ func (c *CPUStats) monitorProcesses() {
}

for pid, stat := range procStats {
memory := stat.RSS * pageSize
stats.Memory[pid] += memory
stats.MemoryTotal += memory

// process usage as percent of total host cpu
procPercentUsage := float64(stat.UTime + stat.STime - prevStats[pid].UTime - prevStats[pid].STime)
if procPercentUsage == 0 {
Expand All @@ -219,10 +223,6 @@ func (c *CPUStats) monitorProcesses() {
cpu := hostCPU * procPercentUsage / 100 / (totalHostTime - prevTotalTime)
stats.Cpu[pid] += cpu
stats.CpuIdle -= cpu

memory := stat.RSS * pageSize
stats.Memory[pid] += memory
stats.MemoryTotal += memory
}

c.idleCPUs.Store(stats.CpuIdle)
Expand Down
Loading