Merged
Conversation
- Update github.com/livetemplate/livetemplate from v0.7.7 to v0.7.12 - Fix avatar-upload test to use Controller+State pattern matching v0.7.12 API - Replace undefined ProfileStore with ProfileState - Update createTestHandler to use lt.Handle(controller, AsState(state)) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR upgrades the livetemplate dependency from v0.7.7 to v0.7.12 and fixes a broken test in the avatar-upload example to use the Controller+State pattern that matches the v0.7.12 API.
Changes:
- Updated
github.com/livetemplate/livetemplatedependency from v0.7.7 to v0.7.12 - Fixed avatar-upload test by replacing undefined
ProfileStorewithProfileStateand updating the test handler to use the Controller+State pattern
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates livetemplate dependency version from v0.7.7 to v0.7.12 |
| go.sum | Updates checksums for livetemplate v0.7.12 |
| avatar-upload/avatar-upload_test.go | Fixes broken test by replacing undefined ProfileStore with ProfileState and updating createTestHandler to use the Controller+State pattern matching v0.7.12 API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- avatar-upload: serve client JS via lvttest.ServeClientLibrary at /livetemplate-client.js - todos: update search tests to use lvt-input attribute with 'input' event (not lvt-change with 'change' event) - todos-components: use text-based waiting for more reliable E2E tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Chat: Use e2etest helpers for consistent port management and server startup - todos-components: Fix test timing by moving navigation outside subtests - todos-components: Use count-based waiting instead of text-based for reliability - todos-components: Add timeout contexts to prevent test hangs - Upgrade lvt to latest for v0.7.12 tree serialization compatibility Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/livetemplate/livetemplatefrom v0.7.7 to v0.7.12ProfileStorewithProfileStatecreateTestHandlerto uselt.Handle(controller, AsState(state))Test plan
ProfileStoreissue was pre-existing (test was broken on main)🤖 Generated with Claude Code