[Refactor] Use short-circuit expression instead repeating check#174
Open
ghabriel25 wants to merge 1 commit intolivewire:mainfrom
Open
[Refactor] Use short-circuit expression instead repeating check#174ghabriel25 wants to merge 1 commit intolivewire:mainfrom
ghabriel25 wants to merge 1 commit intolivewire:mainfrom
Conversation
meduzen
reviewed
Apr 19, 2026
meduzen
approved these changes
Apr 20, 2026
Member
|
I might just be getting old, but I find the 3 separate conditionals easier to read personally 😂 |
Contributor
Author
|
@joshhanley I think its just preference. You might close this one as its not affected how blaze handle the components 👌 |
Member
|
@ghabriel25 agreed! Wait to see what Caleb or Filip think 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small refactor on Memoizer.php
Before
After