Fix compiled path overrides after Blaze runtime resolution#178
Open
prateekbhujel wants to merge 3 commits intolivewire:mainfrom
Open
Fix compiled path overrides after Blaze runtime resolution#178prateekbhujel wants to merge 3 commits intolivewire:mainfrom
prateekbhujel wants to merge 3 commits intolivewire:mainfrom
Conversation
Contributor
Benchmark Result: Default
Median of 10 attempts, 5000 iterations x 10 rounds, 49.75s total To run a specific benchmark, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #177.
BlazeRuntime was caching
view.compiledthe first timecompiledPathwas read. In tenant setups that update the compiled view path after the runtime singleton has already been resolved, Blaze could keep compiling against the original cache directory instead of the tenant-scoped one.This keeps the compiled path dynamic unless it is explicitly overridden, and makes sure the Blade compiler uses that current path before compiling a Blaze component.