feat: Add comprehensive network configuration for remote inference providers #4748
+1,777
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oviders Implemented network configuration support (TLS, proxy, timeout, headers) for all remote inference providers. The NetworkConfig model provides standardized configuration for TLS (including mTLS), proxy servers (with CA cert validation), timeouts (granular connect/read), and custom HTTP headers. Network configuration is automatically applied through OpenAIMixin, merging with provider-specific customizations like OCI's custom auth. Improved type safety by using Path types for certificate paths instead of strings. Simplified client merge logic and added backward compatibility for vLLM's deprecated tls_verify field. Enhanced the provider documentation generator to automatically expand complex types like NetworkConfig, showing all nested fields instead of just type names. All provider documentation has been regenerated with the new network configuration options. Closes: llamastack#4340 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
requested review from
ashwinb,
bbrowning,
cdoern,
ehhuang,
franciscojavierarceo,
mattf and
raghotham
as code owners
meta-cla
bot
added
the
CLA Signed
Signed-off-by: Sébastien Han <seb@redhat.com>
=========================== short test summary info ============================ FAILED tests/unit/providers/utils/inference/test_network_config.py::TestBuildProxyMounts::test_proxy_with_cacert - ssl.SSLError: [X509: NO_CERTIFICATE_OR_CRL_FOUND] no certificate or crl found (_ssl.c:4354) FAILED tests/unit/providers/utils/inference/test_network_config.py::TestBuildProxyMounts::test_granular_proxies_with_cacert - ssl.SSLError: [X509: NO_CERTIFICATE_OR_CRL_FOUND] no certificate or crl found (_ssl.c:4354) Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Sébastien Han <seb@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented network configuration support (TLS, proxy, timeout, headers) for all remote inference providers.
The NetworkConfig model provides standardized configuration for TLS (including mTLS), proxy servers (with CA cert validation), timeouts (granular connect/read), and custom HTTP headers.
Network configuration is automatically applied through OpenAIMixin, merging with provider-specific customizations like OCI's custom auth. Improved type safety by using Path types for certificate paths instead of strings. Simplified client merge logic and added backward compatibility for vLLM's deprecated tls_verify field.
Enhanced the provider documentation generator to automatically expand complex types like NetworkConfig, showing all nested fields instead of just type names. All provider documentation has been regenerated with the new network configuration options.
Closes: #4340
Test Plan
Unit tests.