fix: trim whitespace from discovered branch names #4773
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git branch -r outputs lines with leading spaces (e.g. ' origin/release-0.3.x'). The sed command stripped 'origin/' but not the whitespace, causing the release branch regex to fail and the wrong client version to be installed. Trim whitespace in both the discover-branches step and the install-llama-stack-client action as a safety net. Signed-off-by: Charlie Doern <cdoern@redhat.com>
cdoern
requested review from
ashwinb,
bbrowning,
ehhuang,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
meta-cla
bot
added
the
CLA Signed
leseb
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
git branch -r outputs lines with leading spaces (e.g. ' origin/release-0.3.x'). The sed command stripped 'origin/' but not the whitespace, causing the release branch regex to fail and the wrong client version to be installed.
Trim whitespace in both the discover-branches step and the install-llama-stack-client action as a safety net.
Test Plan
see https://github.com/llamastack/llama-stack/actions/runs/21453322655/job/61787508351 with a successful run!