Skip to content

test - #283

Closed
Jah-yee wants to merge 1 commit into
llm-d:mainfrom
Jah-yee:fix/unparseable-to-unparsable
Closed

test#283
Jah-yee wants to merge 1 commit into
llm-d:mainfrom
Jah-yee:fix/unparseable-to-unparsable

Conversation

@Jah-yee

@Jah-yee Jah-yee commented Aug 6, 2026

Copy link
Copy Markdown

Summary

Fixes typo in pkg/handlers/server_test.go line 443 and 467:

  • unparseableunparsable in a code comment
  • unparseableunparsable in a test case name

Testing

The change is self-explanatory (spelling correction in comment + test name). Go build and tests should pass.

Checklist

  • DCO signed

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

🚨 Unsigned commits detected! Please sign your commits.

For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation.

@github-actions github-actions Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 6, 2026
@nirrozenbaum

Copy link
Copy Markdown
Collaborator

@Jah-yee thank you. can you please fix DCO?

@davidbreitgand

Copy link
Copy Markdown
Contributor

@nirrozenbaum , @Jah-yee FYI: I fixed that in this commit for the pending PR #281 earlier today per CI status catch.

@Jah-yee Jah-yee changed the title fix: correct 'unparseable' to 'unparsable' typo in server_test.go test Aug 7, 2026
@Jah-yee

Jah-yee commented Aug 8, 2026

Copy link
Copy Markdown
Author

Noticed nightly scan just filed issue #282 for the same typo in pkg/handlers/server_test.go:443 (unparseable → unparsable). This PR #283 is already addressing exactly that. Let me know if you need any adjustments!

Corrects typo in comment and test case name.

Signed-off-by: Jah-yee <jydu_seven@outlook.com>
Signed-off-by: Jah-yee <166608075+Jah-yee@users.noreply.github.com>
@Jah-yee Jah-yee closed this Aug 16, 2026
@Jah-yee
Jah-yee force-pushed the fix/unparseable-to-unparsable branch from f1974ae to 36bfae0 Compare August 16, 2026 18:11
@github-actions github-actions Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants