Replace CycleState with request attributes (#288) - #294
Open
szedan-rh wants to merge 1 commit into
Open
Conversation
Store plugin-shared data directly on InferenceRequest via a sync.Map attribute store, matching EPP's pattern. Pass request to response plugin signatures so they can read attributes set during request phase. Delete cycle_state.go entirely. Signed-off-by: szedan <szedan@redhat.com>
github-actions
Bot
added
size/L
5 tasks
ArshVermaGit
left a comment
ArshVermaGit
left a comment
There was a problem hiding this comment.
Could you please add verification for this cleanup? Since this removes cycle_state.go and changes how request-scoped attributes are stored/read through InferenceRequest, it would be good to confirm the related request/response paths and plugin attribute access still work as expected. Also, please clarify whether this PR should be merged together with #288 or independently.
Contributor
Author
|
@nirrozenbaum - could you please review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store plugin-shared data directly on InferenceRequest via a sync.Map
attribute store, matching EPP's pattern. Pass request to response plugin
signatures so they can read attributes set during request phase.
Delete cycle_state.go entirely.
/kind cleanup