Repository navigation
Guard production code against networking - #47
Merged
Merged
Conversation
Signed-off-by: Vijay <evijay@gmail.com>
Signed-off-by: Vijay <evijay@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
cmd/andinternal/, including its dependency graph. Reject HTTP/network APIs, low-level socket calls, unreviewed Cgo and subprocess-launch paths (os/exec,os.StartProcess, low-level process APIs). Parsing helpers remain allowed.--network nonefor investigate (summaries and LiteLLM spend), inspect, diagnose, scan and compare.FROM scratchimage and use the same immutable image ID for both modes. A test-only route probe confirms offline routing is denied without sending packets or depending on an external service.0.7.x.Verification
go test -race -count=1 ./...andgo vet ./...pass.sh scripts/restricted-smoke.sh <built-archive> linux/arm64: all 6 cases pass on Docker Desktop's native Linux/arm64 VM.ENETUNREACHunder none; all CLI outputs and exit codes match. Scan returns its expected exit 3, the other cases exit 0.No production code or installer changes. The guard and smoke are regression protections for the inspected code and exercised paths, not a universal proof about every possible input or dynamic execution path.
Keep this PR in draft. The site no-network statement remains a separate follow-up after both this and site #12 merge. No release requested.