-
Notifications
You must be signed in to change notification settings - Fork 52
Migrate CI to use GitLab Components from radiuss-shared-ci #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit migrates the CI configuration from template-based approach to GitLab CI Components: - Split custom-jobs-and-variables.yml into custom-jobs.yml and custom-variables.yml - Updated .gitlab-ci.yml to use radiuss-shared-ci components - Removed BUILD_ROOT variable (never actually used) - Removed subscribed-pipelines.yml (replaced by inline machine definitions) - Added support for all machines: dane, matrix, corona, tioga, tuolumne - Updated tpl/RAJA submodule to point to woptim/rsci-migrate-to-components branch
0761d27 to
adc179d
Compare
|
@rhornung67 This is ready for review. |
.gitlab/custom-jobs.yml
Outdated
| @@ -0,0 +1,38 @@ | |||
| ############################################################################### | |||
| # Copyright (c) 2017-25, Lawrence Livermore National Security, LLC | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick consistency question. I noticed this header includes dates but the other new files in the PR don't have the date span. Should the date be added to the copyright headers?
Looks like RAJA is including copyright dates in most files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RAJA updated copyright pattern was recently updated. The date should not be here; I removed it.
RAJA updated copyright statements to only include dates in a couple of files. Removed copyright years.
This commit migrates the RAJAPerf CI configuration from the template-based approach to GitLab CI Components (requires GitLab 17.0+). Components provide better versioning, type-safe inputs, and cleaner syntax.
Changes:
The old custom-jobs-and-variables.yml file is retained for backward compatibility but is no longer referenced by the CI configuration.
TODO: