[FIRRTL] Invalids as constants in InferDomains#10022
Draft
Conversation
Treat invalid values as constants in the InferDomains pass. I'm not entirely sure that this is correct given that the FIRRTL spec says that an invalid value can be any value. Hence, there exist both legal and illegal values that could be chosen. Constants are fine. However, a value could be chosen that is on a different domain which would then be illegal. It seems wrong to reject a circuit that has a legal, known solution. However, this then puts the burden on the downstream assigner of invalid values to choose a legal value. AI-assisted-by: Augment (Sonnet 4.5) Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat invalid values as constants in the InferDomains pass.
I'm not entirely sure that this is correct given that the FIRRTL spec says
that an invalid value can be any value. Hence, there exist both legal and
illegal values that could be chosen. Constants are fine. However, a
value could be chosen that is on a different domain which would then be
illegal. It seems wrong to reject a circuit that has a legal, known
solution. However, this then puts the burden on the downstream assigner
of invalid values to choose a legal value.
AI-assisted-by: Augment (Sonnet 4.5)