[SMTToZ3LLVM] Strip dbg.variable and dbg.scope ops (for now)#10102
Merged
[SMTToZ3LLVM] Strip dbg.variable and dbg.scope ops (for now)#10102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some temporary patterns to SMTToZ3LLVM so that we discard dbg.scope and dbg.variable ops - this allows us to insert debug ops to achieve informative naming later on without it breaking further down the pipeline. Eventually we'll want to replace these patterns with handling that takes and uses the debug information for counter-example reporting.
This should allow #10075 to land (and should help smooth out the wider GSoC circt-bmc reporting effort)
(also note that the dbg.scope erasure pattern should be legal as per MLIR FAQ)