Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion offload/include/omptarget.h
Original file line number Diff line number Diff line change
Expand Up @@ -412,8 +412,22 @@ void __tgt_target_data_update_nowait_mapper(
// same action as data_end above. The following types are used; this
// function returns 0 if it was able to transfer the execution to a
// target and an int different from zero otherwise.
struct __tgt_async_info_handle;

__tgt_async_info_handle *__tgt_async_info_create(int64_t DeviceId);

int __tgt_async_info_synchronize(__tgt_async_info_handle *Handle);

void __tgt_async_info_destroy(__tgt_async_info_handle *Handle);

int __tgt_target_kernel(ident_t *Loc, int64_t DeviceId, int32_t NumTeams,
int32_t ThreadLimit, void *HostPtr, KernelArgsTy *Args);
int32_t ThreadLimit, void *HostPtr,
KernelArgsTy *Args);

int __tgt_target_kernel_async(ident_t *Loc, int64_t DeviceId,
int32_t NumTeams, int32_t ThreadLimit,
void *HostPtr, KernelArgsTy *Args,
__tgt_async_info_handle *Handle);

// Non-blocking synchronization for target nowait regions. This function
// acquires the asynchronous context from task data of the current task being
Expand Down
4 changes: 4 additions & 0 deletions offload/libomptarget/exports
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ VERS1.0 {
__tgt_target_data_end;
__tgt_target_data_update;
__tgt_target;
__tgt_target_kernel_async;
__tgt_async_info_create;
__tgt_async_info_synchronize;
__tgt_async_info_destroy;
__tgt_target_teams;
__tgt_target_data_begin_nowait;
__tgt_target_data_end_nowait;
Expand Down
119 changes: 119 additions & 0 deletions offload/libomptarget/interface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,125 @@ bool checkDevice(int64_t &DeviceID, ident_t *Loc) {
return false;
}

struct __tgt_async_info_handle {
int64_t DeviceId;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An AsyncInfoTy has the device ID and you probably don't need another type to wrap it at all.

AsyncInfoTy AsyncInfo;

__tgt_async_info_handle(int64_t DeviceId, DeviceTy &Device)
: DeviceId(DeviceId), AsyncInfo(Device) {}
};

EXTERN __tgt_async_info_handle *
__tgt_async_info_create(int64_t DeviceId) {
assert(PM && "Runtime not initialized");

if (checkDevice(DeviceId, nullptr))
return nullptr;

auto DeviceOrErr = PM->getDevice(DeviceId);
if (!DeviceOrErr)
return nullptr;

return new __tgt_async_info_handle(DeviceId, *DeviceOrErr);
}

EXTERN int __tgt_async_info_synchronize(
__tgt_async_info_handle *Handle) {
if (!Handle)
return OFFLOAD_SUCCESS;

return Handle->AsyncInfo.synchronize();
}

EXTERN void __tgt_async_info_destroy(
__tgt_async_info_handle *Handle) {
if (!Handle)
return;

Handle->AsyncInfo.synchronize();
delete Handle;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle = nullptr?

}

template <typename TargetAsyncInfoTy>
static inline int
targetKernel(ident_t *Loc, int64_t DeviceId, int32_t NumTeams,
int32_t ThreadLimit, void *HostPtr, KernelArgsTy *KernelArgs,
AsyncInfoTy *ExternalAsyncInfo = nullptr) {
assert(PM && "Runtime not initialized");
static_assert(std::is_convertible_v<TargetAsyncInfoTy &, AsyncInfoTy &>,
"Target AsyncInfoTy must be convertible to AsyncInfoTy.");

if (checkDevice(DeviceId, Loc))
return OMP_TGT_FAIL;

if (KernelArgs->Version > OMP_KERNEL_ARG_VERSION)
FATAL_MESSAGE(DeviceId, "Unsupported kernel argument version %u",
KernelArgs->Version);

KernelArgs = upgradeKernelArgs(KernelArgs, NumTeams, ThreadLimit);

auto DeviceOrErr = PM->getDevice(DeviceId);
if (!DeviceOrErr)
FATAL_MESSAGE(DeviceId, "%s",
toString(DeviceOrErr.takeError()).c_str());

std::optional<TargetAsyncInfoTy> OwnedAsyncInfo;

if (!ExternalAsyncInfo) {
OwnedAsyncInfo.emplace(*DeviceOrErr);
ExternalAsyncInfo = &*OwnedAsyncInfo;
}

AsyncInfoTy &AsyncInfo = *ExternalAsyncInfo;

OMPT_IF_BUILT(InterfaceRAII TargetRAII(
RegionInterface.getCallbacks<ompt_target>(), DeviceId,
/*CodePtr=*/HostPtr));

int Rc = target(Loc, *DeviceOrErr, HostPtr, *KernelArgs, AsyncInfo);

if (!OwnedAsyncInfo) {
handleTargetOutcome(Rc == OFFLOAD_SUCCESS, Loc);
return Rc;
}

{
TIMESCOPE_WITH_DETAILS_AND_IDENT("Runtime: synchronize", "", Loc);
if (Rc == OFFLOAD_SUCCESS)
Rc = AsyncInfo.synchronize();
}

handleTargetOutcome(Rc == OFFLOAD_SUCCESS, Loc);
return Rc;
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function looks copied, can we reuse the original instead?


EXTERN int __tgt_target_kernel_async(
ident_t *Loc, int64_t DeviceId, int32_t NumTeams, int32_t ThreadLimit,
void *HostPtr, KernelArgsTy *KernelArgs,
__tgt_async_info_handle *Handle) {
OMPT_IF_BUILT(ReturnAddressSetterRAII RA(__builtin_return_address(0)));

if (!Handle || !KernelArgs) {
handleTargetOutcome(false, Loc);
return OMP_TGT_FAIL;
}

int64_t ResolvedDeviceId = DeviceId;

if (checkDevice(ResolvedDeviceId, Loc))
return OMP_TGT_FAIL;

if (ResolvedDeviceId != Handle->DeviceId) {
handleTargetOutcome(false, Loc);
return OMP_TGT_FAIL;
}

return targetKernel<AsyncInfoTy>(
Loc, ResolvedDeviceId, NumTeams, ThreadLimit, HostPtr, KernelArgs,
&Handle->AsyncInfo);
}


////////////////////////////////////////////////////////////////////////////////
/// adds requires flags
EXTERN void __tgt_register_requires(int64_t Flags) {
Expand Down