Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added offload-wg/meeting-minutes/images/image1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added offload-wg/meeting-minutes/images/image2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added offload-wg/meeting-minutes/images/image3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added offload-wg/meeting-minutes/images/image4.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
141 changes: 141 additions & 0 deletions offload-wg/meeting-minutes/offload-minutes-2024-01-24.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
# Wednesday, Jan 24, 2024, 7:00 - 8:00 am PST

# Agenda (35 people)

1. # Welcome

2. Ics file is broken. Johannes will try again.
3. Offload folder PR: [https://github.com/llvm/llvm-project/pull/77154](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/77154&sa=D&source=editors&ust=1779820787029401&usg=AOvVaw2jBAnkgBVLrk9MTjnpn2OY)
4. Possible API discussions


1. [https://gist.github.com/jhuber6/2117cfd03b7c78d91f5481ac63da682d](https://www.google.com/url?q=https://gist.github.com/jhuber6/2117cfd03b7c78d91f5481ac63da682d&sa=D&source=editors&ust=1779820787030065&usg=AOvVaw1gTqNz6vBPlgVcY9n_BarK)
2. Discussion started, see issue: [https://github.com/llvm/llvm-project/issues/79304](https://www.google.com/url?q=https://github.com/llvm/llvm-project/issues/79304&sa=D&source=editors&ust=1779820787030544&usg=AOvVaw2grbhrR4ErOtpjuisVi3Oc)


1. Stability guarantee?
2. Error handling
3. Nameing, prefix, suffix
4. Source locations
5. Count API invocations
6. Coding style:


1. Clang format everything
2. C++, rules of LLVM
3. API is C?


7. "Language" libraries on top of plugin API:


1. Libllvmomptarget.so, Libllvmkernel.so, Libllvmjulia.so, …


8. Unit testing, coverage testing


5. Next steps:


1. Do we need a separate offload pr subscribe team, something like [https://github.com/orgs/llvm/teams/pr-subscribers-offload](https://www.google.com/url?q=https://github.com/orgs/llvm/teams/pr-subscribers-offload&sa=D&source=editors&ust=1779820787032991&usg=AOvVaw0kZ7Mid7XBftIwDwjpMvJU)?


1. Shilei will take care as soon as the folders exist
2. Labeling (libomptarget, offload)


2. Should we use discourse RFC for key component design discussion instead of llvm issues?
3. ZORG offload builder (as template for people), in addition to OpenMP offload builder.
4. Backward compatibility of user exposed env variables ([https://openmp.llvm.org/design/Runtimes.html#libopenmptarget-environment-vars](https://www.google.com/url?q=https://openmp.llvm.org/design/Runtimes.html%23libopenmptarget-environment-vars&sa=D&source=editors&ust=1779820787034727&usg=AOvVaw1YwA_A-JzwpO_1pjsQ1gpx))



#

* * *

#

# Fri, Jan 12, 2024, 9:00 - 10:00 am PST

# Agenda (27 people)

1. Welcome


* Inline notes


2. Future meetings


* Wednesday 7am pacific, every two weeks.


* Starting Jan 24, 24
* Updates to the OpenMP invite will happen too, two separate invites.


* Alternating with the OpenMP meeting


3. Webpage, docs, etc.


* Talk to Anton for webpage
* Offload folder PR: [https://github.com/llvm/llvm-project/pull/77154](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/77154&sa=D&source=editors&ust=1779820787037383&usg=AOvVaw1KUeK2kVlFaWa5yoJL3V9-)


* Please review


* Sphinx webpage, like Clang and OpenMP (.llvm.org)


4. Initial PRs


* Offload folder PR: [https://github.com/llvm/llvm-project/pull/77154](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/77154&sa=D&source=editors&ust=1779820787038309&usg=AOvVaw0IcEZHvfeyw9tLcG4dSMjj)
* Move libomptarget PR: [https://github.com/llvm/llvm-project/pull/75125](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/75125&sa=D&source=editors&ust=1779820787038786&usg=AOvVaw0NB3X7N6KzVTSH8azoeme1)


* Plan: move then "restore"; Johannes
* Driver switch to pickup liboffload; Joseph


* Offload will become the default path for OpenMP shortly after


5. Naming


* "offload" wins.


6. Working groups


* API Design


* Error model, source information, …


* Testing


* Buildbots, unit tests, lit tests


7. Rust compiler, offload linking


* Will this make it easier for the rust compiler
* Should we include/serve (NVIDIA, AMD, …) libdevice?


* Will talk to Artem


8.
19 changes: 19 additions & 0 deletions offload-wg/meeting-minutes/offload-minutes-2024-02-07.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Wednesday, Feb 7, 2024, 7:00 - 8:00 am PST

# Agenda

325. Removing OpenMP specific operations from the plugin interface
326. Establishing a consistent init / shutdown order (Stop using global constructors)
327. Removing the dynamically opened plugin interface


1. Static libraries instead


328. LLVM/libc things to move into LLVM/offload?



* * *

#
22 changes: 22 additions & 0 deletions offload-wg/meeting-minutes/offload-minutes-2024-02-21.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Wednesday, Feb 21, 2024, 7:00 - 8:00 am PST

# Agenda

322. API Tooling (auto generation of headers, documentation, etc)


1. Brief overview of how we do this in Unified Runtime


323. New PR for the move


1. [https://github.com/llvm/llvm-project/pull/82459](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/82459&sa=D&source=editors&ust=1779820787026322&usg=AOvVaw0R2vX1FH5yGDKQlm6SSYOc)


324.


* * *

#
27 changes: 27 additions & 0 deletions offload-wg/meeting-minutes/offload-minutes-2024-03-06.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Wednesday, March 06, 2024, 7:00 - 8:00 am PST

# Agenda

320. New PR for the move


1. [https://github.com/llvm/llvm-project/pull/82459](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/82459&sa=D&source=editors&ust=1779820787023856&usg=AOvVaw1oMl_uJAgpl-C3legj-iar)



JP can build liboffload.

Add steps in PR on what was done to help downstream to recreate the steps

321. [[Offload][NFC] Add offload subfolder and README #77154](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/77154&sa=D&source=editors&ust=1779820787024458&usg=AOvVaw1VFkqgZt6GaIBNTEdPMJAc)


1. Meeting time needs to be updated (ICS file also?)
2. Should land well in advance before #82459
3. Github llvm teams (pr-subscribers, etc)



* * *

#
41 changes: 41 additions & 0 deletions offload-wg/meeting-minutes/offload-minutes-2024-03-20.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Wednesday, March 20, 2024, 7:00 - 8:00 am PST

# Agenda

316. New PR for the move is done. Zorg patches are up:


1. [https://github.com/llvm/llvm-zorg/pull/141](https://www.google.com/url?q=https://github.com/llvm/llvm-zorg/pull/141&sa=D&source=editors&ust=1779820787020249&usg=AOvVaw3WSvWnQlFKJzbd62h9gi1N)
2. [https://github.com/llvm/llvm-zorg/pull/142](https://www.google.com/url?q=https://github.com/llvm/llvm-zorg/pull/142&sa=D&source=editors&ust=1779820787020492&usg=AOvVaw1C-J8sqmc97KUE6pzl87BU)
3. [https://github.com/llvm/llvm-project/pull/77154](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/77154&sa=D&source=editors&ust=1779820787020713&usg=AOvVaw0xRo3vjPQ-gNi-N0rInliJ)
4. [https://github.com/llvm/llvm-project/pull/75125](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/75125&sa=D&source=editors&ust=1779820787020941&usg=AOvVaw1c5rvbBUc1O3vrd1N5j5ry)


1. Llvm org mailing list


317. PGO for GPUs is a working end-to-end prototype now


1. [https://github.com/EthanLuisMcDonough/llvm-project/tree/gpuprofdriver](https://www.google.com/url?q=https://github.com/EthanLuisMcDonough/llvm-project/tree/gpuprofdriver&sa=D&source=editors&ust=1779820787021427&usg=AOvVaw39IDxk-Lw6Yh34bdy2Sfxc)
2. # Compile with PGO instrumentation
clang -L/dev/shm/YOURNAME/clang/install/lib -L/dev/shm/YOURNAME/clang/install/lib/x86_64-unknown-linux-gnu -fopenmp --offload-arch=native -fprofile-generate-gpu YOUR_FILE.c /dev/shm/YOURNAME/clang/install/lib/x86_64-unknown-linux-gnu/libomptarget.rtl.YOUR_GPU_TARGET.so
# Reprocess data
llvm-profdata merge YOUR_GPU_TARGET.default.profraw -o YOUR_GPU_TARGET.profdata
# Recompile
clang -L/dev/shm/YOURNAME/clang/install/lib -L/dev/shm/YOURNAME/clang/install/lib/x86_64-unknown-linux-gnu -fopenmp --offload-arch=native -fprofile-use-gpu=YOUR_GPU_TARGET.profdata YOUR_FILE.c


318. Tablegen tooling update
319. Testing


1. Keep a list of issues we discuss in the meetings



# Make 1-3 people the "bug keepers"

* * *

#
47 changes: 47 additions & 0 deletions offload-wg/meeting-minutes/offload-minutes-2024-04-03.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# Wednesday, April 3, 2024, 7:00 - 8:00 am PST

# Agenda

312. Statically link plugins


1. [https://github.com/llvm/llvm-project/pull/87009](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/87009&sa=D&source=editors&ust=1779820787017245&usg=AOvVaw0_B1NZktpBdtBakPNPLeR_)


1. Reviews please :)


313. New PR for the move is done. Zorg patches are up:


1. [https://github.com/llvm/llvm-zorg/pull/141](https://www.google.com/url?q=https://github.com/llvm/llvm-zorg/pull/141&sa=D&source=editors&ust=1779820787017665&usg=AOvVaw0dw9vixN8B8SgoIAdtotlj)
2. [https://github.com/llvm/llvm-zorg/pull/142](https://www.google.com/url?q=https://github.com/llvm/llvm-zorg/pull/142&sa=D&source=editors&ust=1779820787017900&usg=AOvVaw3MAFRjkEoFOZnyHl6LE4-1)
3. [https://github.com/llvm/llvm-project/pull/77154](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/77154&sa=D&source=editors&ust=1779820787018166&usg=AOvVaw0yOvmeyKWQrdWZcfrCfrae)
4. [https://github.com/llvm/llvm-project/pull/75125](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/75125&sa=D&source=editors&ust=1779820787018440&usg=AOvVaw375Wo0AsJ-ETs6Im9FDK_w)


1. Llvm org mailing list


5. Ompt + standalone built issues being looked at


314. Offload Buildbot:


1. [https://lab.llvm.org/staging/#/builders/191](https://www.google.com/url?q=https://lab.llvm.org/staging/%23/builders/191&sa=D&source=editors&ust=1779820787019018&usg=AOvVaw1zaa4emJFQDM-bLCBM6LBM)


315. Testing


1. Keep a list of issues we discuss in the meetings
2. Make 1-3 people the "bug keepers"



# GPU/Device PGO working, PRs are being prepared

* * *

#
54 changes: 54 additions & 0 deletions offload-wg/meeting-minutes/offload-minutes-2024-04-17.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# Wednesday, April 17, 2024, 7:00 - 8:00 am PST

# Agenda

306. Statically link plugins


1. [https://github.com/llvm/llvm-project/pull/87009](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/87009&sa=D&source=editors&ust=1779820787013872&usg=AOvVaw0CfOfnhOUO_jz5g4x2e49r)


1. Reviews please :)


307. New PR for the move is done. Zorg patches are up:


1. [https://github.com/llvm/llvm-project/pull/77154](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/77154&sa=D&source=editors&ust=1779820787014397&usg=AOvVaw2-W3Kt6uI3cya_5LGx3Q4O)
2. [https://github.com/llvm/llvm-project/pull/75125](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/75125&sa=D&source=editors&ust=1779820787014622&usg=AOvVaw3qlJSjRxZr2MTsCZ9dxih5)


1. llvm org mailing list


3. Ompt + standalone built issues being looked at


1. [https://github.com/llvm/llvm-project/pull/88957](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/88957&sa=D&source=editors&ust=1779820787015086&usg=AOvVaw1fK11o7LpN9Ti5gn3tuGBd) builds on top of #75125


308. Offload Buildbot:


1. [https://lab.llvm.org/staging/#/builders/191](https://www.google.com/url?q=https://lab.llvm.org/staging/%23/builders/191&sa=D&source=editors&ust=1779820787015394&usg=AOvVaw2xR9ysEJa1ukLOp_v6Y74J)


309. Testing


1. Keep a list of issues we discuss in the meetings
2. Make 1-3 people the "bug keepers"


310. GPU/Device PGO working, PRs are being prepared
311. offload-tblgen


1. [https://github.com/llvm/llvm-project/pull/88923](https://www.google.com/url?q=https://github.com/llvm/llvm-project/pull/88923&sa=D&source=editors&ust=1779820787016111&usg=AOvVaw0boRLBoxUt9COsMMVR1jIy)
2. Parallel Thin LTO (WIP) [https://github.com/ggeorgakoudis/llvm-project/tree/hip-omp-parallel-thinlto](https://www.google.com/url?q=https://github.com/ggeorgakoudis/llvm-project/tree/hip-omp-parallel-thinlto&sa=D&source=editors&ust=1779820787016489&usg=AOvVaw1z9qVxYxqB8YPxR8jEXnDP)



* * *

#
Loading