ci: run 'make check' instead of open-coding two of its five steps - #854
Merged
Merged
Conversation
The lint-and-test job ran 'uv run ruff check' and 'uv run pyright' directly. 'make check' is 'install-js check-message-types' plus ruff, pyright, and 'tsc --noEmit' over static/ — so CI reproduced two of five steps and skipped the rest. Two gates the docs describe as live were running nowhere: - check-message-types, the drift guard on the generated WebSocket message types (message_types.py, message-types.js, websocket-messages.md and tui/src/types.generated.ts). CLAUDE.md says it is 'wired into make check', which was true — but nothing automated ran make check. - check-js, the tsc --noEmit typecheck of static/. That is the same family as the #825/#844 breakage that left the web client dead for three days. This is also why a local node too old to run install-js went unnoticed: CI was green because CI never ran the steps that need node. lint-and-test now sets up node and runs 'make check' as one step, so CI runs the same gate a human runs. Both jobs take the version from .nvmrc rather than a hardcoded '22', so there is one source of truth. Verified: 'make check' passes in a fresh worktree, and a deliberate TS2345 in static/lib/ makes it exit 2 — so the newly-wired JS typecheck has teeth rather than just being present.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The complete check gate now runs in CI with centralized Node versioning.
Pull request overview
Updates CI to run the complete make check gate and centralize Node.js version selection through .nvmrc.
Changes:
- Replaces open-coded Ruff/Pyright steps with
make check. - Adds Node setup to the Python job.
- Uses
.nvmrcin both CI jobs.
File summaries
| File | Description |
|---|---|
.github/workflows/ci.yml |
Runs the complete validation gate with consistent Node setup. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make checkisinstall-js check-message-typesplusruff,pyright, andtsc --noEmitoverstatic/. Thelint-and-testjob open-codeduv run ruff checkanduv run pyrightdirectly — two of those five steps —and skipped the rest.
Two gates that were running nowhere
check-message-typesmessage_types.py,message-types.js,websocket-messages.md,tui/src/types.generated.ts)check-jstsc --noEmitoverstatic/CLAUDE.md says the drift check is "wired into
make check", which was true —but nothing automated ran
make check. Thecheck-jsgap is the same familyas the #825/#844 breakage that left the web client dead for three days with
make checkgreen.This is also the mechanism by which a local Node too old to run
install-jsstayed invisible: CI was green because CI never ran the steps that need Node.
Change
lint-and-testsets up Node and runsmake checkas a single step, so CI runsthe same gate a human runs.
pyteststays its own step. Both jobs now take theNode version from
.nvmrcinstead of a hardcoded'22', so there is onesource of truth — and
.nvmrcstarts actually meaning something in CI.Verification
make checkpasses in a fresh worktree (install-js, drift check, ruff,pyright,
tsc --noEmit), leaving a clean tree.TS2345instatic/lib/mademakeexit 2 and name the error. The probe was anewly created file, removed afterwards, so no existing file was touched.
ci.ymlparses and the step order is uv -> Python -> Node ->uv sync->make check->pytest.Follow-up, not included
tui/is still outside the gate (#725) — no test or typecheck step, and itstypecheck fails on main right now:
SrvShellApprovalwas added totui/src/types.generated.tsby #850 with no matchingdispatcher.tscase.Since
assertNeverhas an empty body and does not throw, shell-approvalmessages silently no-op in the TUI. This PR does gate one TUI file as a side
effect, since
check-message-typesdiffstypes.generated.ts.