Add Gemma 12b Unified Support#334
Merged
Merged
Conversation
will-lms
reviewed
Jun 11, 2026
| or target_verify | ||
| or (isinstance(mask, str) and mask == "left_padded_decode") | ||
| ): | ||
| return OriginalVlmQwen3_5AttentionCall( |
Contributor
There was a problem hiding this comment.
Was thinking about this path wrt caching. My understanding is that we'll route here if a prompt has images and to Qwen3NextAttention if prompt does not.
Have we tested the case where a vision prompt comes in, restores a cache that was previously generated using the text-only route, and then generates? It is not obvious to me that it would work as expected, but hopefully should be close enough either way. Just wondering if we tested such a branch (or if I'm misunderstanding the caching).
Member
Author
There was a problem hiding this comment.
This works as intended, there's no explicit test case for this though
will-lms
approved these changes
Jun 11, 2026
Contributor
|
Reviewed with agentic help. Overall am aligned with decisions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes:
install_mlx_compile_cache_cleanup_for_thread. This bug is already fixed upstream, so we can remove this workaround after the next MLX release