ENG-396: Create ETH-USDT receive address during account creation#351
Open
forge0x wants to merge 1 commit into
Open
ENG-396: Create ETH-USDT receive address during account creation#351forge0x wants to merge 1 commit into
forge0x wants to merge 1 commit into
Conversation
544243c to
e2c7014
Compare
e2c7014 to
3fe93bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates an Ethereum USDT IBEX crypto receive address during Flash account creation, after the ETH-USDT Cash Wallet / IBEX account is created.
This keeps the code on the same IBEX receive-info path that ENG-395 can later expose through GraphQL/mobile.
Changes
account.bridgeEthereumAddressOut of scope
Verification
LOGLEVEL=warn ../../node_modules/.bin/jest --config ./test/flash/unit/jest.config.js --bail --verbose test/flash/unit/app/accounts/create-account.spec.tsgit diff --check../../node_modules/.bin/tsc --noEmit -p tsconfig.d.json../../node_modules/.bin/eslint --no-ignore src/app/accounts/create-account.ts test/flash/unit/app/accounts/create-account.spec.ts../../node_modules/.bin/tsc --noEmitstill fails on inherited baseline legacy/test type errors unrelated to this PR.Linear: ENG-396