ENH: (CLIENTARCHIVER) remove offline_data option and replace it with beamline_data - #1260
Open
xresende wants to merge 2 commits into
Open
ENH: (CLIENTARCHIVER) remove offline_data option and replace it with beamline_data#1260xresende wants to merge 2 commits into
xresende wants to merge 2 commits into
Conversation
Contributor
|
@xresende, what do you mean by still broken? |
Contributor
Author
in my computer communication with the beamline archiver using the class (which works with the machine archiver!) is broken. i started this PR but did not have time to investigate why it is broken. it is probably due to access permissions. but it can also be due to a difference is API since the BLine archiver instance is a newer version. |
xresende
marked this pull request as ready for review
August 13, 2026 16:38
fernandohds564
approved these changes
Aug 13, 2026
vellosok75
reviewed
Aug 14, 2026
| def switch_to_machine_data(self): | ||
| """Switch to machine data. | ||
|
|
||
| Sets server URL to online data URL and logs out if needed. |
Contributor
There was a problem hiding this comment.
Suggested change
| Sets server URL to online data URL and logs out if needed. | |
| Sets server URL to machine data URL and logs out if needed. |
vellosok75
approved these changes
Aug 14, 2026
VitorSouzaLNLS
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new machine archiver appliance now access all data history, rendering deprecated access to "offline" data of previous years. In its place this PR adds the option to access PVs data from the beamlines archiver appliance.
... still broken! Example:
fixed! It seems the problem is that when I tried this code at the firsr time the bline archiver had not implemented the secure interface yet ("https://"). Now it is working...