Add ability to override cell size using env vars#88
Merged
Conversation
Contributor
Author
|
Hi, |
Owner
|
Hey, thanks for the PR (and sorry for the late reaction). |
Contributor
Author
|
Done, rebased this branch on main |
Owner
|
Great, thanks! One last thing -- could you change the commit message to fit conventional commits? (=> |
Contributor
Author
|
Fixed, updated commit message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm working on updating textual integration with xterm.js and want to add proper image rendering in browser. In order to achive it we need to pass actual cell size so
textual-imagecan use correct sizes when will render images.Related PR - Textualize/textual-serve#40
How it looks like in browser:
