Send origin-form URL in HTTP request line. - #48
Open
mleonhard wants to merge 1 commit into
Open
Conversation
Member
|
I would be curious to see if there is a reason why Hyper doesn't do this automatically, I know it does this on HTTP/2 so it strikes me as odd that it isn't specifically done for HTTP/1.1 as well. |
Author
|
@ChillFish8 Would you be interested in merging this PR or sharing some feedback on how to move forward with it? |
Member
|
@mleonhard sorry this is my bad and should have been more clear. I wanted to know why Hyper doesn't do this automatically when it does this for HTTP2 as it makes me believe it is not as simple as always including the origin in the URL request line. Do you have any information on this and if there are any edge cases to this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #47 .
RFC 7230 says that ordinary HTTP requests must use the
/path?querypart of the URL, excluding thehttp://hostpart:It looks like we're sending the absolute-form url
http://127.0.0.1:3000/when we want to send the origin-form url/.We're also omitting the port number in the Location header.
Send the request:
Capture the request:
This PR removes the scheme and authority parts of the URI that we send in the HTTP request line. A URL with only the path and query parts is an origin-form URL.